New issue
Advanced search Search tips

Issue 795586 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

ChannelSplitterNode channelInterpretation should be "discrete".

Reported by gait...@gmail.com, Dec 17 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3297.0 Safari/537.36

Steps to reproduce the problem:
1. create AudioContext , audioctx=new AudioContext()
2. create ChannelSplitterNode , 
 spl=audioctx.createChannelSplitter()
3. check the property, console.log(spl.channelInterpretation) 

What is the expected behavior?
It should be "discrete" in latest spec but remains "speakers"

What went wrong?
If the ChannelSplitter input signal is mono, it would not output to the first output.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 65.0.3297.0  Channel: canary
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M65

Comment 2 by rtoy@chromium.org, Dec 18 2017

Owner: rtoy@chromium.org
Status: Started (was: Unconfirmed)
Thanks for the report.  Yes, it should be "discrete" instead of "speakers".
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa

commit 3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Jan 04 19:05:48 2018

ChannelSplitter.channelInterpretation = 'discrete'

The channelInterprtation for a ChannelSplitterNode should be
'discrete', not 'speakers', and cannot be changed.

Update tests to verify this.

Bug:  795586 
Test: constructors/channelsplitter.html
Change-Id: Icc909ff0ce8652d6fc63b367129da032182f03f2
Reviewed-on: https://chromium-review.googlesource.com/833008
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527052}
[modify] https://crrev.com/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa/third_party/WebKit/LayoutTests/webaudio/constructor/audionodeoptions.js
[modify] https://crrev.com/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
[modify] https://crrev.com/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/3e186bcbdb3b5bc1eb70e132a02776a1fa8241aa/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h

Comment 4 by rtoy@chromium.org, Jan 5 2018

Status: Fixed (was: Started)

Sign in to add a comment