New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795544 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Implement <slot>'s assignedElements()

Project Member Reported by annevank...@gmail.com, Dec 16 2017

Issue description

Comment 1 by kochi@chromium.org, Dec 19 2017

Cc: kochi@chromium.org
Owner: rakina@chromium.org
Status: Assigned (was: Unconfirmed)
Rakina, do you want to work on this?
(this requires intent to implement & ship to blink-dev as well)

Comment 2 by rakina@chromium.org, Dec 26 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1673861ecc8c136aad3448a0d91362f7dfc58963

commit 1673861ecc8c136aad3448a0d91362f7dfc58963
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Mon Jan 15 08:13:37 2018

Implement assignedElements for HTMLSlotElement

The spec for HTMLSlotElement was recently updated, adding the assignedElements
method that returns a slot's assigned nodes, limited to elements. Spec:
https://html.spec.whatwg.org/#dom-slot-assignedelements

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FukpQ-Hvcrs/discussion

Bug:  795544 
Change-Id: I7a2642b594d939e70b7ebdcf2817d71e66ca114a
Reviewed-on: https://chromium-review.googlesource.com/842522
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529226}
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt
[delete] https://crrev.com/dcb17830cb80d702a50eb80b4a18ea687ada1a25/third_party/WebKit/LayoutTests/external/wpt/shadow-dom/slots-expected.txt
[delete] https://crrev.com/dcb17830cb80d702a50eb80b4a18ea687ada1a25/third_party/WebKit/LayoutTests/external/wpt/shadow-dom/slots-fallback-expected.txt
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/Source/core/html/HTMLSlotElement.h
[modify] https://crrev.com/1673861ecc8c136aad3448a0d91362f7dfc58963/third_party/WebKit/Source/core/html/HTMLSlotElement.idl

Comment 4 by rakina@chromium.org, Jan 15 2018

Status: Fixed (was: Started)

Sign in to add a comment