New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795528 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CSS filter blur causes a small translation

Reported by cyril.au...@gmail.com, Dec 16 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Example URL:
https://jsfiddle.net/crl/oasu9wgr/

Steps to reproduce the problem:
1. https://jsfiddle.net/crl/oasu9wgr/
2.
3. 

What is the expected behavior?
it should animate infinitely, the blurriness of the icon, at the exact same position, centered

What went wrong?
observe precisely at time 0 of the animation (not blurred icon) it makes a move of a few px to the top left

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 63.0.3239.84  Channel: n/a
OS Version: 
Flash Version: 

Works on Firefox
 
setting a default blur(0.5px): https://jsfiddle.net/crl/oasu9wgr/1/ can stop this small translation, but it shouldn't be needed
Labels: Needs-Triage-M63

Comment 3 by woxxom@gmail.com, Dec 17 2017

Bisect info: 505198 (good) - 505207 (bad)
https://chromium.googlesource.com/chromium/src/+log/02490123..ec3b4d03?pretty=fuller
Suspecting r505199 "Skia roll" and 5a4fb6eb335d29f24a1b239d1c0eb11b5d2ee59f inside
"Reorganize blur filter to insert new implementation"
Landed in 63.0.3227.0

Also observed in Canary 65.0.3296.0
Components: Blink>Animation
Cc: senorblanco@chromium.org
Components: -Blink>Animation Internals>Skia
Owner: herb@google.com
I minimised the test case a little further: https://jsfiddle.net/oasu9wgr/2/

Bisect suspects Skia patch - over to that team
 Issue 795283  has been merged into this issue.
Cc: vamshi.k...@techmahindra.com
Labels: -Pri-2 -Type-Compat ReleaseBlock-Stable Triaged-ET M-63 OS-Mac Pri-1 Type-Bug-Regression
Status: Assigned (was: Unconfirmed)
As per comment#3 and #5 suspecting the same, Hence assigning it to herb@google.com and changing the status to Assigned.

@herb : Please help in re-assigning it others if it is not related to your change.

Note: Issue is not seen on windows

Please feel free to remove Release-block stable label if not required.

Thanks!

Comment 8 Deleted

Here is another test without icons: https://jsfiddle.net/trbns9bq/

It starts if you HOVER the red block. Also, jumping during the transition.

Chrome 63.0.3239.108 Windows

Comment 10 by herb@google.com, Dec 19 2017

Cc: mtklein@chromium.org
I have found the problem, and a CL is out for review.
Labels: M-64
Cc: abdulsyed@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/dca92e8a622cec7579dd2d44b8b7121603850b93

commit dca92e8a622cec7579dd2d44b8b7121603850b93
Author: Herb Derby <herb@google.com>
Date: Wed Dec 20 14:17:24 2017

Account for border with small sigma.

When sigma is small a very small border is generated,
but no actual blurring happens. Copy the image and
add the small border instead of just copying the image.

Tested by patching into chrome, and observing no shift.

BUG= chromium:795528 

Change-Id: I9eee74a3155575c747fafc71ace77ed4247bcae5
Reviewed-on: https://skia-review.googlesource.com/87420
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>

[modify] https://crrev.com/dca92e8a622cec7579dd2d44b8b7121603850b93/src/core/SkBlurImageFilter.cpp

Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Verified this issue on Mac OS 10.12.6 and Ubuntu 14.04 using chrome latest canary #65.0.3309.0 by using the test case provided in the comment #5. Observed the animation is centered and no translations is seen. Hence marking it as TE-Verified for M65.

Thanks!

Comment 15 by hcm@chromium.org, Jan 2 2018

Labels: -ReleaseBlock-Stable -Needs-Triage-M63
Status: Fixed (was: Assigned)
Fixed on ToT, too longstanding and complex to merge back- removing releaseblock flag.

Comment 16 by hcm@chromium.org, Jan 2 2018

Cc: hcm@chromium.org
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Cc: bsalomon@chromium.org reed@chromium.org
 Issue 796963  has been merged into this issue.
Can you please confirm if we need to merge this in M64?
Labels: -Merge-TBD
Per comment #15, not needed for M64. Removing Merge-TBD label. 
Cc: sc00335...@techmahindra.com
 Issue 800609  has been merged into this issue.

Comment 22 by herb@google.com, Jan 24 2018

Cc: herb@google.com schenney@chromium.org
 Issue 805022  has been merged into this issue.
Observed the same issue in Canary 66.0.3332.0 

https://smartslider3.com/

Comment 24 by woxxom@gmail.com, Jan 26 2018

Confirmed #c23.
Bisecting it produces the same range as for this issue (see #c3) so apparently the bug was not fixed fully.

Comment 25 by herb@google.com, Jan 26 2018

Looking at the original fiddle from #c1 at chromium head, and comparing that to 63.0.3239.132, the problem is fixed. The smartslider3 seems to be intentionally bumping larger the text and buttons in their animation. If you can find a different example of the bump larger, can you please open a different bug.

Sign in to add a comment