Issue metadata
Sign in to add a comment
|
CSS filter blur causes a small translation
Reported by
cyril.au...@gmail.com,
Dec 16 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Example URL: https://jsfiddle.net/crl/oasu9wgr/ Steps to reproduce the problem: 1. https://jsfiddle.net/crl/oasu9wgr/ 2. 3. What is the expected behavior? it should animate infinitely, the blurriness of the icon, at the exact same position, centered What went wrong? observe precisely at time 0 of the animation (not blurred icon) it makes a move of a few px to the top left Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? N/A Does this work in other browsers? Yes Chrome version: 63.0.3239.84 Channel: n/a OS Version: Flash Version: Works on Firefox
,
Dec 17 2017
,
Dec 17 2017
Bisect info: 505198 (good) - 505207 (bad) https://chromium.googlesource.com/chromium/src/+log/02490123..ec3b4d03?pretty=fuller Suspecting r505199 "Skia roll" and 5a4fb6eb335d29f24a1b239d1c0eb11b5d2ee59f inside "Reorganize blur filter to insert new implementation" Landed in 63.0.3227.0 Also observed in Canary 65.0.3296.0
,
Dec 18 2017
,
Dec 19 2017
I minimised the test case a little further: https://jsfiddle.net/oasu9wgr/2/ Bisect suspects Skia patch - over to that team
,
Dec 19 2017
Issue 795283 has been merged into this issue.
,
Dec 19 2017
As per comment#3 and #5 suspecting the same, Hence assigning it to herb@google.com and changing the status to Assigned. @herb : Please help in re-assigning it others if it is not related to your change. Note: Issue is not seen on windows Please feel free to remove Release-block stable label if not required. Thanks!
,
Dec 19 2017
Here is another test without icons: https://jsfiddle.net/trbns9bq/ It starts if you HOVER the red block. Also, jumping during the transition. Chrome 63.0.3239.108 Windows
,
Dec 19 2017
I have found the problem, and a CL is out for review.
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/dca92e8a622cec7579dd2d44b8b7121603850b93 commit dca92e8a622cec7579dd2d44b8b7121603850b93 Author: Herb Derby <herb@google.com> Date: Wed Dec 20 14:17:24 2017 Account for border with small sigma. When sigma is small a very small border is generated, but no actual blurring happens. Copy the image and add the small border instead of just copying the image. Tested by patching into chrome, and observing no shift. BUG= chromium:795528 Change-Id: I9eee74a3155575c747fafc71ace77ed4247bcae5 Reviewed-on: https://skia-review.googlesource.com/87420 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com> [modify] https://crrev.com/dca92e8a622cec7579dd2d44b8b7121603850b93/src/core/SkBlurImageFilter.cpp
,
Jan 2 2018
Verified this issue on Mac OS 10.12.6 and Ubuntu 14.04 using chrome latest canary #65.0.3309.0 by using the test case provided in the comment #5. Observed the animation is centered and no translations is seen. Hence marking it as TE-Verified for M65. Thanks!
,
Jan 2 2018
Fixed on ToT, too longstanding and complex to merge back- removing releaseblock flag.
,
Jan 2 2018
,
Jan 2 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 2 2018
,
Jan 2 2018
Can you please confirm if we need to merge this in M64?
,
Jan 4 2018
Per comment #15, not needed for M64. Removing Merge-TBD label.
,
Jan 10 2018
,
Jan 24 2018
,
Jan 26 2018
Observed the same issue in Canary 66.0.3332.0 https://smartslider3.com/
,
Jan 26 2018
Confirmed #c23. Bisecting it produces the same range as for this issue (see #c3) so apparently the bug was not fixed fully.
,
Jan 26 2018
Looking at the original fiddle from #c1 at chromium head, and comparing that to 63.0.3239.132, the problem is fixed. The smartslider3 seems to be intentionally bumping larger the text and buttons in their animation. If you can find a different example of the bump larger, can you please open a different bug.
,
Jan 26 2018
Thanks #c25, I opened two new issue as they both exists in Canary: https://bugs.chromium.org/p/chromium/issues/detail?id=806293 https://bugs.chromium.org/p/chromium/issues/detail?id=806291 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by cyril.au...@gmail.com
, Dec 16 2017