ProfileAttributesStorageTest.LoadAvatarFromDiskTest did not write the test icon correctly |
|||
Issue descriptionBy vadamish@: https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_attributes_storage_unittest.cc?type=cs&q=ProfileAttributesStorageTest&sq=package:chromium&l=814 writes only 8 bytes to the file, because sizeof(bitmap) is 8 (with 'bitmap' being a pointer). You should change "const char* bitmap" to "const char bitmap[]".
,
Jan 16 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c602d4eb8a37e78a3ae81428b8981e58af807dd commit 6c602d4eb8a37e78a3ae81428b8981e58af807dd Author: WC Leung <lwchkg@chromium.org> Date: Tue Jan 23 22:32:18 2018 Bug fixes of ProfileAttributesStorageTest.LoadAvatarFromDiskTest The captioned test was disabled in Linux ASAN because of flakiness. Two possible causes were identified: - Possible race between DownloadHighResAvatarTest and LoadAvatarFromDiskTest because the path returned by GetPathOfHighResAvatarAtIndex is not inside the unique temp directory. - The directory holding the test icon is not created before running base::WriteFile. This CL fixes the above issues, and changed "const char* bitmap" to "const char bitmap[]" because of issue 795518 . Bug: 794821 , 795518 Change-Id: I0deb2c8acddea86fb94ca27a363afa132f0ac6fc Reviewed-on: https://chromium-review.googlesource.com/868411 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: WC Leung <lwchkg@chromium.org> Cr-Commit-Position: refs/heads/master@{#531370} [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_attributes_storage_unittest.cc [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_info_cache_unittest.cc [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_info_cache_unittest.h [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/test/base/testing_profile_manager.cc [modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/test/base/testing_profile_manager.h
,
Jan 23 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Jan 15 2018