New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ProfileAttributesStorageTest.LoadAvatarFromDiskTest did not write the test icon correctly

Project Member Reported by lwchkg@chromium.org, Dec 16 2017

Issue description

By vadamish@: https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_attributes_storage_unittest.cc?type=cs&q=ProfileAttributesStorageTest&sq=package:chromium&l=814 writes only 8 bytes to the file, because sizeof(bitmap) is 8 (with 'bitmap' being a pointer). You should change "const char* bitmap" to "const char bitmap[]".


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 15 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by lwchkg@chromium.org, Jan 16 2018

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c602d4eb8a37e78a3ae81428b8981e58af807dd

commit 6c602d4eb8a37e78a3ae81428b8981e58af807dd
Author: WC Leung <lwchkg@chromium.org>
Date: Tue Jan 23 22:32:18 2018

Bug fixes of ProfileAttributesStorageTest.LoadAvatarFromDiskTest

The captioned test was disabled in Linux ASAN because of flakiness. Two
possible causes were identified:

- Possible race between DownloadHighResAvatarTest and
  LoadAvatarFromDiskTest because the path returned by
  GetPathOfHighResAvatarAtIndex is not inside the unique temp directory.

- The directory holding the test icon is not created before running
  base::WriteFile.

This CL fixes the above issues, and changed "const char* bitmap" to
"const char bitmap[]" because of  issue 795518 .


Bug:  794821 ,  795518 
Change-Id: I0deb2c8acddea86fb94ca27a363afa132f0ac6fc
Reviewed-on: https://chromium-review.googlesource.com/868411
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: WC Leung <lwchkg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531370}
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_attributes_storage_unittest.cc
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/browser/profiles/profile_info_cache_unittest.h
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/test/base/testing_profile_manager.cc
[modify] https://crrev.com/6c602d4eb8a37e78a3ae81428b8981e58af807dd/chrome/test/base/testing_profile_manager.h

Comment 4 by lwchkg@chromium.org, Jan 23 2018

Status: Fixed (was: Started)

Sign in to add a comment