Add a flag to run VR APIs in a low-integrity process.
Moving to M66
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/876dcfb734188a400d174705f5b8454e0a1ffc4b commit 876dcfb734188a400d174705f5b8454e0a1ffc4b Author: Bill Orr <billorr@chromium.org> Date: Tue May 22 17:57:10 2018 Remove dead VR Pause code. We have several concepts of focus/active/etc for VR headsets. One of these represents menu mode, where the browser temporarily unfocuses a VR experience. This is not hooked up currently, so we have stale code. This dead code would otherwise need to be converted when VRDevice is mojoified, so removing for now. If we want to add back a similar way to pause experiences, we can easily add it back. BUG=795510 Change-Id: Ifba2d7d6f23ba668c5f259a9326acb4983f13836 Reviewed-on: https://chromium-review.googlesource.com/1068097 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560697} [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/chrome/browser/android/vr/gl_browser_interface.h [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/device/vr/vr_device.h [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/device/vr/vr_device_base.cc [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/device/vr/vr_device_base.h [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/device/vr/vr_display_impl.cc [modify] https://crrev.com/876dcfb734188a400d174705f5b8454e0a1ffc4b/device/vr/vr_display_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aee4fd632563f290234c7b2c0890fa5b797aeedc commit aee4fd632563f290234c7b2c0890fa5b797aeedc Author: Bill Orr <billorr@chromium.org> Date: Tue May 22 22:48:19 2018 Remove access to VRDeviceManager::GetDevice. In anticipation of making VRDevice a mojo interface, this change starts to trim back where VRDevice is used. VRShellDelegate can, for now, still use GvrDevice, which can maintain current functionality. BUG=795510 Change-Id: I37b4c9b8c914c5f271464ee7488d0002ffa208ac Reviewed-on: https://chromium-review.googlesource.com/1068025 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#560821} [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/chrome/browser/android/vr/vr_shell_delegate.h [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/device/vr/android/gvr/gvr_delegate_provider_factory.cc [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/device/vr/android/gvr/gvr_delegate_provider_factory.h [modify] https://crrev.com/aee4fd632563f290234c7b2c0890fa5b797aeedc/device/vr/android/gvr/gvr_device.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51 commit e0bdede2a0bd71b75860ff65d4e29735ecdb5d51 Author: Bill Orr <billorr@chromium.org> Date: Thu May 24 20:10:20 2018 Create a BrowserXrDevice that sits between VRDevice and VRDisplayHost. As part of moving devices to a mojo interface, the browser process needs to make some decision synchronously, so we need some state management browser-side. The browser should be deciding which sites are presenting, and which pages can receive various events, including activation. BUG=795510 Change-Id: I38282b71b5134938c6670f016acd303851adc5da Reviewed-on: https://chromium-review.googlesource.com/1060637 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561595} [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/BUILD.gn [add] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/browser_xr_device.cc [add] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/browser_xr_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/chrome/browser/vr/service/vr_service_impl.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/oculus/oculus_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/openvr/openvr_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/test/fake_vr_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/test/mock_vr_display_impl.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/test/mock_vr_display_impl.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_device.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_device_base.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_device_base.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_display_impl.cc [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_display_impl.h [modify] https://crrev.com/e0bdede2a0bd71b75860ff65d4e29735ecdb5d51/device/vr/vr_display_impl_unittest.cc
Retitled - meaning is still the same, but the flag is a small part despite being the prior title.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88023f28bf27d822eb4c29f657f3ab4c10317f6a commit 88023f28bf27d822eb4c29f657f3ab4c10317f6a Author: Bill Orr <billorr@chromium.org> Date: Thu May 31 21:19:08 2018 Trim down VRDisplayImpl, so it can be more easily mojoified Remove VRDisplayImpl's knowledge about focus and activation. Separate VRDisplayImpls calls coming from browser to an interface that can be mojoified. RequestSession will be removed from VRDisplayImpl in a subsequent change, but leaving for now to avoid merge conflicts. Bug: 795510 Change-Id: I9549ae24ec1759c19c7b7d3c41966a34cde05c5b Reviewed-on: https://chromium-review.googlesource.com/1077200 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#563377} [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/chrome/browser/android/vr/arcore_device/arcore_device.h [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/test/fake_vr_service_client.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/test/fake_vr_service_client.h [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/test/mock_vr_display_impl.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/vr_device_base.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/vr_device_base.h [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/vr_display_impl.cc [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/vr_display_impl.h [modify] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dbec8fddc42686451b535e349a3d22393e85a5b commit 4dbec8fddc42686451b535e349a3d22393e85a5b Author: Bill Orr <billorr@chromium.org> Date: Fri Jun 01 21:19:09 2018 Make VRDevice ids hardcoded based on type, and remove synchronous GetId As VRDevices are mojoified, we will have some devices that live in separate processes from others. We won't be able to share a single static variable to ensure globally unique IDs. All providers hand out at most one device, so we are safe to hardcode IDs based on runtime API. There is no privacy concern because in addition to Ids, we already hand out information about the devices. There is little compat concern, because devices are still returned in an array to sites, so sites using the first device will continue to work. As we move to WebXR, there will only be a single device returned (with different session types), so this will be moot. BUG=795510 Change-Id: Icd262a42b9a0b7a5daf2159141852e32b9a1ac07 Reviewed-on: https://chromium-review.googlesource.com/1079636 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#563799} [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/android/vr/arcore_device/arcore_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/oculus/oculus_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/oculus/oculus_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/openvr/openvr_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/openvr/openvr_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/orientation/orientation_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/orientation/orientation_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/orientation/orientation_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/test/fake_vr_device.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/test/fake_vr_device_provider.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_device.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_device_base.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_device_base.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_device_provider.h [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/device/vr/vr_display_impl_unittest.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc [modify] https://crrev.com/4dbec8fddc42686451b535e349a3d22393e85a5b/third_party/blink/renderer/modules/vr/vr_display.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214 commit 2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214 Author: Bill Orr <billorr@chromium.org> Date: Wed Jun 06 21:27:01 2018 Make Exclusive sessions use XrSessionController to stop/ExitPresent. As part of Mojoification of VRDevice, this change removes ExitPresent, and moves exclusive session management out of the VRDevice interface. BUG=795510 Change-Id: I60c7dca54b62eb518e1895d7a2d0df628fbd84d8 Reviewed-on: https://chromium-review.googlesource.com/1087718 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565039} [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/chrome/browser/vr/service/browser_xr_device.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/chrome/browser/vr/service/browser_xr_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/oculus/oculus_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/openvr/openvr_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/test/fake_vr_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/vr_device.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/vr_device_base.cc [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/vr_device_base.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/vr_display_impl.h [modify] https://crrev.com/2d1b9c732c2bbb4e8c3e96afb4160ab08fb1d214/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f793e16665dca752ab572ba1852e27049563417f commit f793e16665dca752ab572ba1852e27049563417f Author: Bill Orr <billorr@chromium.org> Date: Fri Jun 29 19:38:36 2018 Create mojo interfaces to replace VRDevice, XrSessionController Devices are converted over to XrRuntime. Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 Reviewed-on: https://chromium-review.googlesource.com/1093386 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#571595} [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/arcore_device/arcore_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/arcore_device/arcore_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell_delegate.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/browser_xr_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/browser_xr_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_render_loop.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/oculus/oculus_render_loop.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_render_loop.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/openvr/openvr_render_loop.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/orientation/orientation_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/orientation/orientation_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/orientation/orientation_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/orientation/orientation_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/public/mojom/BUILD.gn [add] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/public/mojom/README.md [add] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/public/mojom/isolated_xr_service.mojom [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/fake_vr_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/fake_vr_device_provider.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/mock_vr_display_impl.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/test/mock_vr_display_impl.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_device.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_device_base.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_device_base.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_device_provider.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_display_impl.cc [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_display_impl.h [modify] https://crrev.com/f793e16665dca752ab572ba1852e27049563417f/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0ce7bce604688d38338129e85671a32ecefc5eb commit f0ce7bce604688d38338129e85671a32ecefc5eb Author: Bill Orr <billorr@chromium.org> Date: Fri Jun 29 23:46:26 2018 Revert "Create mojo interfaces to replace VRDevice, XrSessionController" This reverts commit f793e16665dca752ab572ba1852e27049563417f. Reason for revert: Some tests are broken - I'll revert to investigate then reland. Original change's description: > Create mojo interfaces to replace VRDevice, XrSessionController > > Devices are converted over to XrRuntime. > > Bug: 795510 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 > Reviewed-on: https://chromium-review.googlesource.com/1093386 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571595} TBR=dcheng@chromium.org,mthiesse@chromium.org,billorr@chromium.org,offenwanger@chromium.org Change-Id: I496be5fe20f9dc67999aa0cac86c41f79206e841 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1121497 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571710} [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/arcore_device/arcore_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/arcore_device/arcore_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell_delegate.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/browser_xr_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/browser_xr_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_render_loop.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/oculus/oculus_render_loop.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_render_loop.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/openvr/openvr_render_loop.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/orientation/orientation_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/orientation/orientation_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/orientation/orientation_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/orientation/orientation_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/public/mojom/BUILD.gn [delete] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/device/vr/public/mojom/README.md [delete] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/device/vr/public/mojom/isolated_xr_service.mojom [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/fake_vr_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/fake_vr_device_provider.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/mock_vr_display_impl.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/test/mock_vr_display_impl.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_device.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_device_base.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_device_base.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_device_provider.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_display_impl.cc [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_display_impl.h [modify] https://crrev.com/f0ce7bce604688d38338129e85671a32ecefc5eb/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be7e1da3699810b6a73bd1d93069a6fd2163ace4 commit be7e1da3699810b6a73bd1d93069a6fd2163ace4 Author: Bill Orr <billorr@chromium.org> Date: Sat Jun 30 02:10:14 2018 Reland "Create mojo interfaces to replace VRDevice, XrSessionController" This reverts commit f0ce7bce604688d38338129e85671a32ecefc5eb. Reason for revert: Found the issue with tests, will rebase with fix. Original change's description: > Revert "Create mojo interfaces to replace VRDevice, XrSessionController" > > This reverts commit f793e16665dca752ab572ba1852e27049563417f. > > Reason for revert: Some tests are broken - I'll revert to investigate then reland. > > Original change's description: > > Create mojo interfaces to replace VRDevice, XrSessionController > > > > Devices are converted over to XrRuntime. > > > > Bug: 795510 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 > > Reviewed-on: https://chromium-review.googlesource.com/1093386 > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#571595} > > TBR=dcheng@chromium.org,mthiesse@chromium.org,billorr@chromium.org,offenwanger@chromium.org > > Change-Id: I496be5fe20f9dc67999aa0cac86c41f79206e841 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 795510 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1121497 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571710} TBR=dcheng@chromium.org,mthiesse@chromium.org,billorr@chromium.org,offenwanger@chromium.org Change-Id: Ibe4d12804afc6482dc53623436ed1126d1885fc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1121636 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571740} [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/arcore_device/arcore_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/arcore_device/arcore_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell_delegate.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/browser_xr_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/browser_xr_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_device_manager.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_render_loop.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/oculus/oculus_render_loop.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_render_loop.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/openvr/openvr_render_loop.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/orientation/orientation_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/orientation/orientation_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/orientation/orientation_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/orientation/orientation_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/public/mojom/BUILD.gn [add] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/public/mojom/README.md [add] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/public/mojom/isolated_xr_service.mojom [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/fake_vr_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/fake_vr_device_provider.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/mock_vr_display_impl.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/test/mock_vr_display_impl.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_device.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_device_base.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_device_base.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_device_provider.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_display_impl.cc [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_display_impl.h [modify] https://crrev.com/be7e1da3699810b6a73bd1d93069a6fd2163ace4/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718 commit fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718 Author: Bill Orr <billorr@chromium.org> Date: Fri Aug 03 04:40:23 2018 Support running Oculus gamepads out of the browser process Third party code will be blocked in the browser process. We'll need to host VR input outside the browser process. To support that, we need some IPC mechanism to get gamepad data over to the browser process where the device/gamepad service is hosted. For now, we'll host OpenVR gamepad data in the same place we host the OculusRenderLoop. This is not the final shipping location, but adding an IPC mechanism moves us closer to the final architecture. BUG=795510, 860821 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib63489c36e3e08723d9e4f92327fb97aa77597a9 Reviewed-on: https://chromium-review.googlesource.com/1147742 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580452} [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/BUILD.gn [add] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/isolated_gamepad_data_fetcher.cc [add] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/isolated_gamepad_data_fetcher.h [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_device.h [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_device_provider.cc [delete] https://crrev.com/fc68244099e90afbf6e2f49d36687d6bca7c28a8/device/vr/oculus/oculus_gamepad_data_fetcher.cc [delete] https://crrev.com/fc68244099e90afbf6e2f49d36687d6bca7c28a8/device/vr/oculus/oculus_gamepad_data_fetcher.h [add] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_gamepad_helper.cc [add] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_gamepad_helper.h [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_render_loop.cc [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/oculus/oculus_render_loop.h [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/public/mojom/BUILD.gn [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/public/mojom/README.md [modify] https://crrev.com/fbfc4209ea7c824fb2eb6c4b14a6117b3cf8a718/device/vr/public/mojom/isolated_xr_service.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0a84c3c241bc3d6c2967a281475b6d375d438eb commit d0a84c3c241bc3d6c2967a281475b6d375d438eb Author: Bill Orr <billorr@chromium.org> Date: Fri Aug 03 17:14:36 2018 Support running OpenVR gamepads out of the browser process Third party code will be blocked in the browser process. We'll need to host VR input outside the browser process. To support that, we need some IPC mechanism to get gamepad data over to the browser process where the device/gamepad service is hosted. For now, we'll host OpenVR gamepad data in the same place we host the OculusRenderLoop. This is not the final shipping location, but adding an IPC mechanism moves us closer to the final architecture. BUG=795510, 860821 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8385d1c4222df9636259743366f64eafbb40fa3a Reviewed-on: https://chromium-review.googlesource.com/1153561 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580578} [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/BUILD.gn [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_device.h [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_device_provider.cc [delete] https://crrev.com/4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25/device/vr/openvr/openvr_gamepad_data_fetcher.cc [delete] https://crrev.com/4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25/device/vr/openvr/openvr_gamepad_data_fetcher.h [add] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_gamepad_helper.cc [add] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_gamepad_helper.h [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_render_loop.cc [modify] https://crrev.com/d0a84c3c241bc3d6c2967a281475b6d375d438eb/device/vr/openvr/openvr_render_loop.h
Removing Internals>VR component and assigning to Internals>XR
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb42922e8a7206ee62806d05b8fb736fbae3e18f commit eb42922e8a7206ee62806d05b8fb736fbae3e18f Author: Bill Orr <billorr@chromium.org> Date: Wed Aug 08 21:14:43 2018 Create a service for VR devices to be hosted outside browser process This change creates a service for hosting desktop VR devices so they can be run at the appropriate level of sandboxing required to ship. The browser process will consume this service to enable WebVR/WebXR support to ship on Windows. Currently the service runs in a utility process with no sandbox. A subsequent change will enable an appropriate sandbox behind a flag to enable testing. Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d602f4db91bcd1ddb5a3edf535f90e126004d4a Reviewed-on: https://chromium-review.googlesource.com/1155754 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581694} [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/app/BUILD.gn [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/app/vr_strings.grdp [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/BUILD.gn [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/DEPS [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/android/vr/arcore_device/arcore_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/android/vr/arcore_device/arcore_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/android/vr/vr_shell_delegate.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/android/vr/vr_shell_delegate.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/BUILD.gn [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/service/isolated_device_provider.cc [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/service/isolated_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/service/xr_runtime_manager.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/service/xr_runtime_manager.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/browser/vr/service/xr_runtime_manager_unittest.cc [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/BUILD.gn [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/DEPS [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/OWNERS [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/manifest.json [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/xr_device_service.cc [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/xr_device_service.h [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/xr_runtime_provider.cc [add] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/services/isolated_xr_device/xr_runtime_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/utility/BUILD.gn [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/utility/DEPS [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/cardboard_gamepad_data_fetcher.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/cardboard_gamepad_data_fetcher.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/android/gvr/gvr_gamepad_data_fetcher.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/buildflags/BUILD.gn [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/buildflags/buildflags.gni [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/isolated_gamepad_data_fetcher.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/isolated_gamepad_data_fetcher.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/oculus/oculus_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/oculus/oculus_device.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/oculus/oculus_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/oculus/oculus_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/openvr/openvr_device.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/openvr/openvr_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/openvr/openvr_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/orientation/orientation_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/orientation/orientation_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/orientation/orientation_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/public/mojom/isolated_xr_service.mojom [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/public/mojom/vr_service.mojom [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_device.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_device_provider.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_display_impl_client.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_service_client.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/test/fake_vr_service_client.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_device.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_device_base.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_device_base.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_device_provider.h [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/device/vr/vr_display_impl_unittest.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/third_party/blink/renderer/modules/vr/vr_display.cc [modify] https://crrev.com/eb42922e8a7206ee62806d05b8fb736fbae3e18f/third_party/blink/renderer/modules/vr/vr_display.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efbc5da49d709c609b63e5efc477b7843ce3735d commit efbc5da49d709c609b63e5efc477b7843ce3735d Author: Bill Orr <billorr@chromium.org> Date: Tue Sep 18 21:21:25 2018 Make WebXR browser tests pass when XR devices run in a service This change introduces a mojo interface for browser tests to control the behavior of OpenVR running in the XR device service. BUG=795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95a6a0c9a57ff0e174b337026b34866c43fff058 Reviewed-on: https://chromium-review.googlesource.com/1166468 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592196} [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/vr/test/mock_openvr_device_hook_base.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/vr/test/mock_openvr_device_hook_base.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/vr/test/xr_browser_test.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/browser/vr/webxr_vr_pixel_browser_test.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/BUILD.gn [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/manifest.json [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_device_service.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_device_service.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_runtime_provider.h [add] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_test_hook_registration.cc [add] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_test_hook_registration.h [add] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_test_hook_wrapper.cc [add] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/chrome/services/isolated_xr_device/xr_test_hook_wrapper.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/BUILD.gn [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/buildflags/buildflags.gni [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/openvr_api_wrapper.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/openvr_api_wrapper.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/test/fake_openvr_impl_api.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/test/test_helper.cc [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/test/test_helper.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/openvr/test/test_hook.h [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/public/mojom/BUILD.gn [modify] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/public/mojom/README.md [add] https://crrev.com/efbc5da49d709c609b63e5efc477b7843ce3735d/device/vr/public/mojom/browser_test_interfaces.mojom
clearing Milestone for now. Looks like maybe M71?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecfb9fece26ead8044ef732ec18161ac4b47dab4 commit ecfb9fece26ead8044ef732ec18161ac4b47dab4 Author: Bill Orr <billorr@chromium.org> Date: Tue Oct 02 00:11:10 2018 Add a flag to make VR compositing happen in a low-integrity AppContainer. Currently VR APIs on desktop are hosted in an unsandboxed process when enabled. After this change, VR Apis may be hosted in an AppContainer low-integrity process when a flag is enabled. This allows debugging sandbox issues before enabling VR by default. BUG=795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie16dd86cfa23171b0025359cd7e2d4db7997a9e7 Reviewed-on: https://chromium-review.googlesource.com/1162763 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: James Forshaw <forshaw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595657} [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/browser/about_flags.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/browser/flag_descriptions.h [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/browser/vr/service/isolated_device_provider.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/browser/vr/service/isolated_device_provider.h [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/chrome/services/isolated_xr_device/manifest.json [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/content/browser/utility_process_host.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/features.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/features.h [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/sandbox_type.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/sandbox_type.h [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/switches.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/switches.h [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/services/service_manager/sandbox/win/sandbox_win.cc [modify] https://crrev.com/ecfb9fece26ead8044ef732ec18161ac4b47dab4/tools/metrics/histograms/enums.xml
Comment 1 by ddorwin@chromium.org
, Dec 16 2017