New issue
Advanced search Search tips

Issue 795490 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CPDF_ShadingPattern::Load

Project Member Reported by ClusterFuzz, Dec 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4721491622232064

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  CPDF_ShadingPattern::Load
  CPDF_StreamContentParser::Handle_ShadeFill
  CPDF_StreamContentParser::Parse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=524458:524459

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4721491622232064

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 16 2017

Labels: OS-Mac
Project Member

Comment 2 by ClusterFuzz, Dec 16 2017

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Dec 16 2017

Labels: Test-Predator-Auto-Owner
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/3208356db199098d1110780e138b74b6436deb0b (Validate shading pattern's ColorSpace. It cannot be a Pattern CS.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Cc: hnakashima@chromium.org
 Issue 795491  has been merged into this issue.
Owner: thestig@chromium.org
Easy fix.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/682118834b3cf2b5510ee676088fdd8f11869e84

commit 682118834b3cf2b5510ee676088fdd8f11869e84
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Dec 16 06:52:48 2017

Fix null-dereference in CPDF_ShadingPattern::Load().

BUG= chromium:795490 
TBR=hnakashima@chromium.org

Change-Id: Ic9f12c1c709c148f7294ab2aaf65fcc695960835
Reviewed-on: https://pdfium-review.googlesource.com/21530
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/682118834b3cf2b5510ee676088fdd8f11869e84/core/fpdfapi/page/cpdf_shadingpattern.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Dec 17 2017

ClusterFuzz has detected this issue as fixed in range 524599:524600.

Detailed report: https://clusterfuzz.com/testcase?key=4721491622232064

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  CPDF_ShadingPattern::Load
  CPDF_StreamContentParser::Handle_ShadeFill
  CPDF_StreamContentParser::Parse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=524458:524459
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=524599:524600

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4721491622232064

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Dec 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4721491622232064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
 Issue 795532  has been merged into this issue.
Cc: ivancic@google.com
 Issue 795521  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 18 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/9ecd41496d25a077adfafc975ad201c3fc15b60a

commit 9ecd41496d25a077adfafc975ad201c3fc15b60a
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Mon Dec 18 20:41:23 2017

[Merge M64] Fix null-dereference in CPDF_ShadingPattern::Load().

BUG= chromium:795490 
TBR=hnakashima@chromium.org

Change-Id: Ic9f12c1c709c148f7294ab2aaf65fcc695960835
Reviewed-on: https://pdfium-review.googlesource.com/21530
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
(cherry picked from commit 682118834b3cf2b5510ee676088fdd8f11869e84)
Reviewed-on: https://pdfium-review.googlesource.com/21630
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/9ecd41496d25a077adfafc975ad201c3fc15b60a/core/fpdfapi/page/cpdf_shadingpattern.cpp

 Issue 795889  has been merged into this issue.

Sign in to add a comment