New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795480 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome: update experimental CWP profiles to 64.0.3280.5

Project Member Reported by llozano@chromium.org, Dec 16 2017

Issue description

This version has a fix for the issue where external symbols were added to the profile. 
 
Labels: Merge-Request-64
external symbols should not be in the profile. They were increasing the size of the profile and confusing the counts.

We need to put this fix in R64 branch.

Project Member

Comment 2 by sheriffbot@chromium.org, Dec 19 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fdec75aa4545de75d5676b749689ac18f1710ff3

commit fdec75aa4545de75d5676b749689ac18f1710ff3
Author: Luis A. Lozano <llozano@google.com>
Date: Wed Dec 20 08:34:04 2017

chrome: update experimental CWP profile to 64.0.3280.5.

Fixed issue with external symbols showing up in the profile.

BUG= chromium:795480 
TEST=cros tryjob falco-release

Change-Id: Ice4a0436e5d7e6d80196a59187e6148473f2abd8
Reviewed-on: https://chromium-review.googlesource.com/831347
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/fdec75aa4545de75d5676b749689ac18f1710ff3/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/fdec75aa4545de75d5676b749689ac18f1710ff3/chromeos-base/chromeos-chrome/Manifest

can I please get an approval for M64?
Labels: M-64
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 22 2017

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/af6359ace9719e7196f98eec68d32ea715d1e62e

commit af6359ace9719e7196f98eec68d32ea715d1e62e
Author: Luis Lozano <llozano@chromium.org>
Date: Fri Dec 22 07:00:31 2017

chrome: update experimental CWP profile to 64.0.3280.5.

Fixed issue with external symbols showing up in the profile.

BUG= chromium:795480 
TEST=cros tryjob falco-release

Change-Id: Iadb1694160a8188e54988073fada791a717725b9
Reviewed-on: https://chromium-review.googlesource.com/842088
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Trybot-Ready: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/af6359ace9719e7196f98eec68d32ea715d1e62e/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/af6359ace9719e7196f98eec68d32ea715d1e62e/chromeos-base/chromeos-chrome/Manifest

Components: Infra

Comment 9 by mmoss@chromium.org, Jan 2 2018

Components: -Infra Infra>Client>ChromeOS
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
Components: -Infra>Client>ChromeOS
Status: Verified (was: Assigned)
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 12 2018

Cc: kbleicher@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-64

Sign in to add a comment