Replace PasswordManager::OnSameDocumentNavigation with OnPasswordFormSubmittedNoChecks |
||||
Issue descriptionPasswordManager::OnInPageNavigation is called as signal that submission is happened and PasswordManager should not check it's success (because it was already checked, or success checking should be skipped).
,
Jun 27 2018
This is now called OnSameDocumentNavigation and it forwards to OnPasswordFormSubmittedNoChecks. Because the former is the only caller of the latter, let's just remove OnSameDocumentNavigation and replace it with OnPasswordFormSubmittedNoChecks. Assigning temporarily to jdoerrie@ to block this as a starter project for the coming intern. If the intern does not end up fixing this, we should release it again as Available.
,
Jul 3
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fea7d7ae3226f0466d6d7997137ffd04a88f712 commit 6fea7d7ae3226f0466d6d7997137ffd04a88f712 Author: Gemene Narcis <gemene@google.com> Date: Tue Jul 03 16:14:25 2018 Replace PasswordManager::OnSameDocumentNavigation with PasswordManager::OnPasswordFormSubmittedNoChecks The OnSameDocumentNavigation forwards to OnPasswordFormSubmittedNoChecks and because the former is the only caller of the latter remove OnSameDocumentNavigation and replace it with OnPasswordFormSubmittedNoChecks. R=jdoerrie@chromium.org Bug: 795462 Change-Id: I2097b748c630559d5922288e2d0832c8b819de83 Reviewed-on: https://chromium-review.googlesource.com/1124472 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572246} [modify] https://crrev.com/6fea7d7ae3226f0466d6d7997137ffd04a88f712/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/6fea7d7ae3226f0466d6d7997137ffd04a88f712/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/6fea7d7ae3226f0466d6d7997137ffd04a88f712/components/password_manager/core/browser/password_manager.h [modify] https://crrev.com/6fea7d7ae3226f0466d6d7997137ffd04a88f712/components/password_manager/core/browser/password_manager_unittest.cc
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6e6610c7c559c94761c4a9b25fa7981ea2c5edf commit c6e6610c7c559c94761c4a9b25fa7981ea2c5edf Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Jul 04 08:46:36 2018 Fix a minor typo in password_manager.h A space between two sentences was missing in a comment, so this CL adds it. Bug: 795462 Change-Id: Iaa1e92b411f919e34cd8a3737dcd289f85fecdf6 Reviewed-on: https://chromium-review.googlesource.com/1125660 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572515} [modify] https://crrev.com/c6e6610c7c559c94761c4a9b25fa7981ea2c5edf/components/password_manager/core/browser/password_manager.h
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kolos@chromium.org
, Jan 8 2018