New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795461 link

Starred by 1 user
Status: Fixed
Owner:
█ pschmidt@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
npm@chromium.org
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Upgrade PDFium Windows bots to Windows 10

Project Member Reported by thestig@chromium.org, Dec 16 2017 
Most PDFium developers use Windows 10, but the bots use Windows 7. With modern FreeType in PDFium, there are minor font rendering differences on Windows 7 and 10. It'll be easier for developers if our bots matched our development machines.

This will probably have to wait until 2018, as it will require a bit of coordination to update the PDFium test expectations.

Also, we have another pending request for new Windows machines in bug 795451. If it is inconvenient to add Windows 7 bots, and do more work to switch them out for Windows 10, then we can hold off on bug 795451 and do that after this.

Comment 1 by thestig@chromium.org, Dec 16 2017 

To be specific, this is for the client.pdfium and tryserver.client.pdfium waterfalls.

Comment 2 by thestig@chromium.org, Dec 21 2017

Components: Infra

Comment 3 by katthomas@google.com, Dec 21 2017

Components: -Infra

Comment 4 by katthomas@google.com, Dec 21 2017

Components: Infra>Labs

Comment 5 by pschm...@google.com, Dec 21 2017 

How about we provide you 12 new gce based win10 slaves.  This would cover the existing 10 windows slaves and the two additional ones from 795451.

Then we will reclaim the stale ones after you have made the switch.

Comment 6 by pschm...@google.com, Dec 21 2017

Owner: pschmidt@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by thestig@chromium.org, Dec 21 2017 

That works. We'll need time to adjust PDFium to Windows 10, so we'll work on the switch over in 2018.

Comment 8 by pschmidt@chromium.org, Dec 27 2017 

Issue 795451 has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 27 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/a6a7280bf8057ade85302dc2832c19cb13a3143f

commit a6a7280bf8057ade85302dc2832c19cb13a3143f
Author: Peter Schmidt <pschmidt@google.com>
Date: Wed Dec 27 17:44:48 2017

Comment 10 by pschmidt@chromium.org, Dec 27 2017

Status: Started (was: Assigned)
You were asking for 4 and not 2 more slaves in 795451, making it a total of 14.

So for client.pdfium:  win{31,32,33,45,46,211]-c3
For tryserver.client.pdfium:  win{1608..1615}-c4

Comment 11 by thestig@chromium.org, Jan 10 2018 

This sounds good. Thanks. Now on the PDFium side, we have to switch over.

Right now we have 4 machines on master.client.pdfium and 6 on master.tryserver.client.pdfium. We have 6 and 8 new machines ready for the respective waterfalls. 14 is the right count.

Comment 12 by thestig@chromium.org, Jan 11 2018 

I think I'll start by putting the -c4 bots to work as FYI trybots.

Comment 13 by b...@chromium.org, Mar 30 2018

Status: Fixed (was: Started)

Comment 14 by thestig@chromium.org, Apr 2 2018 

We'll continue the upgrade in  bug 828177  and eventually release the Win 7 bots.
►

Sign in to add a comment