New issue
Advanced search Search tips

Issue 795460 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Gamepad


Sign in to add a comment

No mapping for Logitech dual-mode gamepads in "D" mode on Windows or Linux/ChromeOS

Project Member Reported by mattreynolds@chromium.org, Dec 16 2017

Issue description

The F310, F510, and F710 are gamepads that support both XInput and DirectInput modes. They behave similarly and can use the same mapper.

On Windows, the F510 and F710 are supported in "X" mode through GamepadPlatformDataFetcherWin but not "D" mode which is handled in RawInputDataFetcher. A mapper for the F310 is already present and should be used for the other devices.

On Linux and Chrome OS, all three gamepads are supported in "X" mode but none have a mapper for "D" mode. The "D" mode mapper should be ported from the Windows implementation.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36e98cc3e2dfd3caebb2cbe20f22ced668fe027

commit b36e98cc3e2dfd3caebb2cbe20f22ced668fe027
Author: Matt Reynolds <mattreynolds@chromium.org>
Date: Fri Mar 02 20:33:01 2018

Add mapping for Logitech Fx10 gamepads in D-mode on Windows

The Logitech F310, F510, and F710 gamepads have a switch to allow the
device to operate in either XInput mode or DirectInput mode. On
Windows, we currently recognize these gamepads as XInput devices
when in X-mode but have incomplete or missing mappings in D-mode.

This CL adds a mapping for these devices in D-mode. Some features are
not available in D-mode, e.g. the Meta button, analog trigger values,
and haptic feedback.

BUG=795460

Change-Id: Ic61f4983d358fcad0ae7f31d70d989437802beee
Reviewed-on: https://chromium-review.googlesource.com/935498
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540608}
[modify] https://crrev.com/b36e98cc3e2dfd3caebb2cbe20f22ced668fe027/device/gamepad/gamepad_standard_mappings_win.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d7e127aeab8526a8f989e5349eb9b53b394d47

commit 22d7e127aeab8526a8f989e5349eb9b53b394d47
Author: Matt Reynolds <mattreynolds@chromium.org>
Date: Fri Mar 02 20:43:52 2018

Add mapping for Logitech Fx10 gamepads in D-mode on Linux

The Logitech F310, F510, and F710 gamepads have a switch to allow the
device to operate in either XInput mode or DirectInput mode. On Linux,
we currently only have a mapping for the XInput mode, causing the
gamepad to use the default (incorrect) mapping in DirectInput mode.

This CL adds a mapping for these devices in D-mode. Some features are
not available in D-mode, e.g. the Meta button and analog trigger values.

BUG=795460

Change-Id: I81286a55c9e496f082c7123ea8aa34b5e09a5403
Reviewed-on: https://chromium-review.googlesource.com/935479
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540616}
[modify] https://crrev.com/22d7e127aeab8526a8f989e5349eb9b53b394d47/device/gamepad/gamepad_standard_mappings_linux.cc

Sign in to add a comment