Port VR instrumentation tests to browser tests |
|||
Issue descriptionNow that VR browser tests are available, we should port any instrumentation test cases that make sense on desktop to them. This should be some subset of the WebVR tests since the VR Browser isn't supported on desktop yet.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2426e7fc0b5fe947a5df168c21de357cb9bed7c1 commit 2426e7fc0b5fe947a5df168c21de357cb9bed7c1 Author: bsheedy <bsheedy@chromium.org> Date: Tue Dec 19 23:45:53 2017 Port window.rAF VR test to desktop Adds TestWindowRafFiresWhilePresenting to the VR browser tests, which is equivalenlent to WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting on Android, but is different since there are different expectations between Android and desktop. Bug: 795455 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I10aa3390e52bea78537af4cf0d4a9a64fbc3a1b9 Reviewed-on: https://chromium-review.googlesource.com/834760 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525185} [modify] https://crrev.com/2426e7fc0b5fe947a5df168c21de357cb9bed7c1/chrome/browser/vr/test/vr_transition_utils.cc [modify] https://crrev.com/2426e7fc0b5fe947a5df168c21de357cb9bed7c1/chrome/browser/vr/test/vr_transition_utils.h [modify] https://crrev.com/2426e7fc0b5fe947a5df168c21de357cb9bed7c1/chrome/browser/vr/webvr_transition_browser_test.cc [add] https://crrev.com/2426e7fc0b5fe947a5df168c21de357cb9bed7c1/chrome/test/data/vr/e2e_test_files/html/test_window_raf_fires_while_presenting.html
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe2c9b07629d1f19c2a95a447ee0fdcd0e9c7937 commit fe2c9b07629d1f19c2a95a447ee0fdcd0e9c7937 Author: bsheedy <bsheedy@chromium.org> Date: Thu Dec 21 21:24:59 2017 Port WebVrTabTest.java to browser tests Ports the one test in WebVrTabTest.java to also be a VR browser test. Bug: 795455 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib929779c3f9c5175f43b952854c6e3d3cc6c2559 Reviewed-on: https://chromium-review.googlesource.com/837597 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525805} [add] https://crrev.com/fe2c9b07629d1f19c2a95a447ee0fdcd0e9c7937/chrome/browser/vr/webvr_tab_browser_test.cc [modify] https://crrev.com/fe2c9b07629d1f19c2a95a447ee0fdcd0e9c7937/chrome/test/BUILD.gn
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80c88c5f2e38809780dad854b33447d8041eec61 commit 80c88c5f2e38809780dad854b33447d8041eec61 Author: bsheedy <bsheedy@chromium.org> Date: Fri Jan 05 22:10:32 2018 Refactor VR browser test cmd line arg code Renames VrBrowserTest to be VrBrowserTestBase and refactors how it handles command line arguments. This allows subclasses to easily change the command line args used for a particular test and is the functional equivalent of the @CommandLine.Add/Remove annotations used in the instrumentation tests. As a result, the gtest filter for running VR browser tests is changed to VrBrowserTest* instead of VrBrowserTest.* in order to include subclasses. Also adds several desktop WebVR tests using this new functionality. Bug: 795455 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2cc281ea080c7a37e5edcbbb3f91330e3893d7af Reviewed-on: https://chromium-review.googlesource.com/851340 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#527406} [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/chrome/browser/vr/test/vr_browser_test.cc [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/chrome/browser/vr/test/vr_browser_test.h [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/chrome/browser/vr/test/vr_transition_utils.cc [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/chrome/browser/vr/webvr_tab_browser_test.cc [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/chrome/browser/vr/webvr_transition_browser_test.cc [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/80c88c5f2e38809780dad854b33447d8041eec61/testing/buildbot/chromium.gpu.fyi.json
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237a467558f273d1b02a2aaf9ca844a5e9d67995 commit 237a467558f273d1b02a2aaf9ca844a5e9d67995 Author: bsheedy <bsheedy@chromium.org> Date: Thu Jan 11 17:46:17 2018 Add Windows VR focus lock test Ports WebVrInputTest#testPresentationLocksFocus to a browser test for use on Windows. Bug: 795455 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic11e9bbaf7b1edd211698b7109d11908284e6ea9 Reviewed-on: https://chromium-review.googlesource.com/861327 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#528664} [add] https://crrev.com/237a467558f273d1b02a2aaf9ca844a5e9d67995/chrome/browser/vr/webvr_input_browser_test.cc [modify] https://crrev.com/237a467558f273d1b02a2aaf9ca844a5e9d67995/chrome/test/BUILD.gn
,
Jul 4
,
Aug 7
Removing Internals>VR component and assigning to Internals>XR
,
Aug 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 18 2017