New issue
Advanced search Search tips

Issue 795433 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Add a test case for spelling marker removal on user disabling spellcheck

Project Member Reported by xiaoche...@chromium.org, Dec 15 2017

Issue description

We need a test case for the behavior that:

When disabling the spellcheck feature (via context menu or settings), all spelling markers in all frames should be removed.

Now that the marker removal logic has been moved to components/spellcheck/renderer/spellcheck.cc, we need a new test case for this behavior.

Basic idea:

1. Start a renderer process with a mock browser

2. Add mock SpellCheckHost or SpellCheckMessageFilter to the mock browser, depending on the platform, so that the renderer can get spellcheck results

3. Load some HTML, trigger spellchecker, and wait until marker appears

4. Call SpellCheck::Initialize() with enable=false, to mock the user preference change that spellcheck is disabled

5. Assert that all spelling markers are removed

 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment