New issue
Advanced search Search tips

Issue 795430 link

Starred by 2 users
Status: Fixed
Owner:
sdy@chromium.org
Closed: Jan 2018
Cc:
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD downloads buttons should use the SF monospace numbers font

Project Member Reported by shrike@chromium.org, Dec 15 2017 
Chrome Version: 65.0.3295.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Visit a page like http://www.newsweek.com/andy-weir-author-martian-his-new-book-artemis-and-who-he-wants-cast-movie-711337
(2) File -> Save the page

With the San Francisco monospace numbers font the byte count updates would look smoother (they won't jerk to the left and right as narrower glyphs like "1" come into and out of use).
NotMonospace.mov
586 KB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8786d7bbb1c82becd1e6958f2dbb64e86ed6dd34

commit 8786d7bbb1c82becd1e6958f2dbb64e86ed6dd34
Author: Sidney San Martín <sdy@chromium.org>
Date: Fri Jan 05 23:50:37 2018

Use a monospaced digit font for download progress.

Also make downloads slightly wider to avoid truncation (because status
text takes up more space with this font).

Bug:  795430 
Change-Id: I71e938ab723d1bedda20bb9c3173e98d3b3bb735
Reviewed-on: https://chromium-review.googlesource.com/852395
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527433}
[modify] https://crrev.com/8786d7bbb1c82becd1e6958f2dbb64e86ed6dd34/chrome/browser/ui/cocoa/download/md_download_item_view.mm

Comment 2 Deleted

Comment 3 by sdy@chromium.org, Jan 6 2018

Cc: bettes@chromium.org
+bettes@ FYI: Because this makes the status text slightly wider, I increased the width of download items from 239pt to 245pt. Hopefully this is okay.

Comment 4 by sandeepkumars@chromium.org, Jan 8 2018 

Tested the issue using #65.0.3315.0 on Mac 10.12.6 as per the steps mentioned in original comment.

@shrike: Could you please find the attatched screencast and confirm about the fix.

Thanks!!
795430.webm
5.3 MB View Download

Comment 5 by sandeepkumars@chromium.org, Jan 8 2018

Labels: Needs-Feedback

Comment 6 by sdy@chromium.org, Jan 8 2018 

Hi sandeepkumars@, this actually only affects the MD download shelf, which you may have to turn on in chrome://flags/#mac-md-download-shelf.

Comment 7 by sdy@chromium.org, Jan 8 2018

Labels: -Needs-Feedback
(Removing Needs-Feedback for now)

Comment 8 by shrike@chromium.org, Jan 8 2018 

Hello sandeepkumars@,

It doesn't look like sdy@'s change is in the latest Canary - I expect it will be there tomorrow.

sdy@, it seems like sandeepkumars@ is testing the MD downloads version? I see the circular download progress indicator in the screencast.

Comment 9 by sdy@chromium.org, Jan 8 2018 

The one in c#4 is definitely the current/old download shelf.
►

Sign in to add a comment