New issue
Advanced search Search tips

Issue 795419 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Context menu for bookmark folders should support adding new folder

Project Member Reported by sky@chromium.org, Dec 15 2017

Issue description

Clicking on a new folder in the bookmark manager and creating a subfolder is a common operation that should be possible from the context menu. We support this for the bookmark bar context menu, so why not the bookmark manager context menu?

I watched my wife try to create a new folder last night. She was baffled until I suggested clicking the three dot menu (not the Chrome three dot menu, but the bookmark three dot menu). I realize hidden UI is all the rage these days, but actual physical buttons are easy to see without having to click around. Please consider real buttons for common operations.
 

Comment 1 by meh...@chromium.org, Dec 16 2017

Labels: Proj-MaterialDesign-WebUI
Confirmed. This was the case in the old Pre-MD Bookmark Manager.

Please find attached 2 screenshots.
folder_button_context_Menu.png
20.3 KB View Download
right_click_context_menu.png
44.0 KB View Download
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Please also add Cut/Copy/Paste into the context menu. Many users from Chrome Help Forum are stumped because they are too used to right-click bookmarks to access Cut/Copy/Paste.

It is possible to use keyboard shortcuts to cut/copy/paste, but many users are uncomfortable with keyboard shortcuts. Context menu is more intuitive.
Also consider to make the 3-dot menu icon more visible. Many users from Chrome Help Forum did not realize it is actually "Organize" button in old UI.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043c7cb9efab319aee82ffd0b8c97f01b67260d1

commit 043c7cb9efab319aee82ffd0b8c97f01b67260d1
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jan 09 06:02:29 2018

[MD Bookmarks] Unify toolbar menu.

This CL unifies the toolbar menu into the bookmarks command manager. This
will allow easy addition of a small context menu for adding bookmarks and
folders when clicking the blank areas of the bookmark list.

Bug:  795419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I65c373a94e5f39e6c74c7ef959ad6b3610c89883
Reviewed-on: https://chromium-review.googlesource.com/851593
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527912}
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/chrome/test/data/webui/md_bookmarks/toolbar_test.js
[modify] https://crrev.com/043c7cb9efab319aee82ffd0b8c97f01b67260d1/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fde6178f33aabb91266c9c931cad42028c206c8d

commit fde6178f33aabb91266c9c931cad42028c206c8d
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Jan 11 04:27:07 2018

[MD Bookmarks] Add right click menu to bookmark list.

This CL adds a context menu to the bookmark list that has "Add Bookmark"
and "Add Folder".

Bug:  795419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4789fe281ef96c47974963fbcb003aa94e744d3b
Reviewed-on: https://chromium-review.googlesource.com/853795
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528560}
[modify] https://crrev.com/fde6178f33aabb91266c9c931cad42028c206c8d/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/fde6178f33aabb91266c9c931cad42028c206c8d/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/fde6178f33aabb91266c9c931cad42028c206c8d/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/fde6178f33aabb91266c9c931cad42028c206c8d/chrome/test/data/webui/md_bookmarks/list_test.js

Please at least add Cut, Copy, Paste and Undo delete to context menu.

There is currently no way to cut/copy/paste without keyboard shortcut.

There *is* a way to undo delete without keyboard shortcut: click the button in <iron-toast> after deletion, but it disappears very quickly.
Screenshot (36).png
94.8 KB View Download
Status: Fixed (was: Assigned)
Filed  Issue 805738  for Cut/Copy/Paste. Marking this fixed.

Sign in to add a comment