New issue
Advanced search Search tips

Issue 795400 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 760320



Sign in to add a comment

Viz Content Unittests Not initializing CompositorFrameSinkSupport

Project Member Reported by jonr...@chromium.org, Dec 15 2017 
When running content_unittests with --enable-viz the DelegatedFrameHost does not create its CompositorFrameSinkSupport.

So when tests call into it they crash.

viz::CompositorFrameSinkSupport::SubmitCompositorFrame this=0x0
content::DelegatedFrameHost::SubmitCompositorFrame
...

Failing tests:
  RenderWidgetHostViewAuraCopyRequestTest.DedupeFrameSubscriberRequests
  RenderWidgetHostViewAuraCopyRequestTest.DestroyedAfterCopyRequest
  RenderWidgetHostViewAuraCopyRequestTest.PresentTime
  
  RenderWidgetHostViewAuraSurfaceSynchronizationTest.CompositorFrameSinkChange
  RenderWidgetHostViewAuraSurfaceSynchronizationTest.DiscardDelegatedFrames
  RenderWidgetHostViewAuraSurfaceSynchronizationTest.DropFallbackWhenHidden
  RenderWidgetHostViewAuraSurfaceSynchronizationTest.SurfaceChanges
  RenderWidgetHostViewAuraTest.DelegatedFrameGutter
  RenderWidgetHostViewAuraTest.DiscardDelegatedFrames
  RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithLocking
  RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure
  RenderWidgetHostViewAuraTest.ForwardsBeginFrameAcks
  RenderWidgetHostViewAuraTest.HitTestRegionListSubmitted
  RenderWidgetHostViewAuraTest.MissingFramesDontLock
  RenderWidgetHostViewAuraTest.OutputSurfaceIdChange
  RenderWidgetHostViewAuraTest.ResizeAfterReceivingFrame
  RenderWidgetHostViewAuraTest.SkippedDelegatedFrames
  RenderWidgetHostViewAuraTest.TwoOutputSurfaces

Comment 1 by jonr...@chromium.org, Dec 15 2017 

And RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface

Comment 2 by jonr...@chromium.org, May 23 2018

Status: Assigned (was: Untriaged)
All of these are obsolete, directly calling SubmitCompositorFrame I will disable and add to the list to delete
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07dde099338e0d01778556a1af377b72c31bc91c

commit 07dde099338e0d01778556a1af377b72c31bc91c
Author: jonross <jonross@chromium.org>
Date: Fri May 25 14:23:18 2018

Disable RenderWidgetHostViewAuraTest and RenderWidgetHostViewAuraSurfaceSynchronizationTest on Viz

A series of tests within RenderWidgetHostViewAuraTest and
RenderWidgetHostViewAuraSurfaceSynchronizationTest are failing on Viz. However
they are actually obsolete once Viz is the default. This disables them and adds
a note for me to remove them once Viz is on by default

TEST=RenderWidgetHostViewAuraTest, RenderWidgetHostViewAuraSurfaceSynchronizationTest

Bug:  795400 
Change-Id: Ia23cc1758b6010e475dd62a7bc51a62b78a65582
Reviewed-on: https://chromium-review.googlesource.com/1070312
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561862}
[modify] https://crrev.com/07dde099338e0d01778556a1af377b72c31bc91c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/07dde099338e0d01778556a1af377b72c31bc91c/testing/buildbot/filters/viz.content_unittests.filter

Comment 4 by jonr...@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment