New issue
Advanced search Search tips

Issue 795398 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Feb 2018
Cc:
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Printing: Use PDF from print preview data store when printing to local printers.

Project Member Reported by rbpotter@chromium.org, Dec 15 2017 
Currently, we use the PDF that has already been generated for Print Preview for every type of printing except local printing (PDF, cloud, privet, extension). For local printers we re-render the PDF, which is an extra step and requires a separate code path in PrintPreviewHandler. We should make the code more consistent across different printer types and skip the extra rendering step by using the PDF from the data store for local printers as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a5f376dae006f46357175f8d47f3b46b965fd4

commit f5a5f376dae006f46357175f8d47f3b46b965fd4
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 15 22:33:22 2017

Use the PDF in PrintPreviewDataStore for local printers

To improve consistency with other printer types and avoid a second
round of rendering, use the PDF stored in the print preview data
store for local printers.

Bug:  795398 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d3423efb8b473ef862491b203bb18eb172e6458
Reviewed-on: https://chromium-review.googlesource.com/704262
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524493}
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/local_printer_handler_default.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/local_printer_handler_default.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/printer_capabilities.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/printer_capabilities.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/printer_handler.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/browser/ui/webui/print_preview/printer_handler.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/components/printing/common/print_messages.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/components/printing/renderer/print_render_frame_helper.h
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/components/printing/test/print_render_frame_helper_browsertest.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/printing/print_job_constants.cc
[modify] https://crrev.com/f5a5f376dae006f46357175f8d47f3b46b965fd4/printing/print_job_constants.h

Comment 2 by rbpotter@chromium.org, Feb 12 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment