Viz Content Unittests Crash in content::RenderWidgetHostImpl::SubmitCompositorFrame |
||||
Issue descriptionWhen running content_unittests with --enable viz we do not initialize viz related components. When content::RenderWidgetHostImpl::SubmitCompositorFrame runs it calls renderer_compositor_frame_sink_->DidReceiveCompositorFrameAck(resources) This crashes in mojo code as the |receiver_| is null. Tests will need a mock viz::mojom::CompositorFrameSinkClientPtr to stub this out. Failing tests: RenderWidgetHostTest.FrameToken_RendererCrash RenderWidgetHostTest.NewContentRenderingTimeout RenderWidgetHostTest.SwapCompositorFrameWithBadSourceId
,
Jan 17 2018
,
Jan 17 2018
Also see: CompositorFrameSinkInterceptorForTesting as an autogenerated mock which may assist if a non-trivial mock is needed.
,
Jan 19 2018
I don't think we should worry about tests that call SubmitCompositorFrame. These tests should be removed or replaced with a viz-friendly version. The CL I'm working on right now basically disables RenderWidgetHostTest.NewContentRenderingTimeout and RenderWidgetHostTest.SwapCompositorFrameWithBadSourceId when surface sync is on.
,
Jan 19 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb22bb2686842c314e06f3d0471bcc344a12cd3 commit 2fb22bb2686842c314e06f3d0471bcc344a12cd3 Author: Shridhar Sundarraj <sundarrajs@google.com> Date: Wed Jan 24 20:40:40 2018 Content Unittest Crash Fix in RenderWidgetHostImpl::SubitCompositorFrame Content unittests crash when they call RenderWidgetHostImpl::SubmitCompositorFrame because it calls renderer_compositor_frame_sink_->DidReceiveCompositorFrameAck(resources) that tries to dereference a nullptr (|receiver_|). In my change, I stub out |renderer_compositor_frame_sink_| with a mock in each failing content unittest, by replacing CompositorFrameSinkClientPtr (|renderer_compositor_frame_sink_|) with a CompositorFrameSinkClientPtr bound to MockCompositorFrameSinkClient. Bug: 795397 Change-Id: Ibb820023332c7c6d2203b6e48549043ec0aa638f Reviewed-on: https://chromium-review.googlesource.com/875013 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Shridhar Sundarraj <sundarrajs@google.com> Cr-Commit-Position: refs/heads/master@{#531671} [modify] https://crrev.com/2fb22bb2686842c314e06f3d0471bcc344a12cd3/content/browser/renderer_host/render_widget_host_unittest.cc
,
Jan 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jonr...@chromium.org
, Jan 16 2018Status: Available (was: Untriaged)