Fuchsia: GetVDAErrorCounterForRunningOutOfPendingBuffers is flaky |
|||
Issue descriptionhttps://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/12231 [ RUN ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForRunningOutOfPendingBuffers/0 GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: Decode(@0x15b8a98ed950 136-byte object <00-00 00-00 00-00 00-00 03-C9 89-19 00-00 00-00 C0-B6 99-6E 21-51 3B-86 B6-19 AB-26 31-95 33-80 00-10 00-00 00-00 00-00 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>) NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. ../../content/renderer/media/gpu/rtc_video_decoder_unittest.cc:381: Failure Expected equality of these values: -1 rtc_decoder_->Decode(input_image, false, nullptr, nullptr, 0) Which is: 0 ../../content/renderer/media/gpu/rtc_video_decoder_unittest.cc:382: Failure Expected equality of these values: 1 rtc_decoder_->GetVDAErrorCounterForTesting() Which is: 0
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f65aaffda1c2404eaf600c31fcc595b46f83227 commit 7f65aaffda1c2404eaf600c31fcc595b46f83227 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Dec 18 19:18:13 2017 Disable GetVDAErrorCounterForRunningOutOfPendingBuffers The test is flaky and it fails often on Fuchsia. Bug: 795387 Change-Id: I3a293955be42087811543e24522247e22a540865 TBR: emircan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/832911 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524757} [modify] https://crrev.com/7f65aaffda1c2404eaf600c31fcc595b46f83227/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
,
Dec 18 2017
Enircan, PTAL when you have time. I'm not sure if there is a good way to fix this test, so maybe just remove it?
,
Dec 18 2017
Issue 795524 has been merged into this issue.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5516e6184566b7594b97cbb0e53b4b45e7af337 commit f5516e6184566b7594b97cbb0e53b4b45e7af337 Author: Emircan Uysaler <emircan@chromium.org> Date: Wed Jan 17 04:45:27 2018 Fix test flakiness for GetVDAErrorCounterForRunningOutOfPendingBuffers This CL adresses the flakiness in the test due to assumption about task scheduling. It drains all tasks after each Decode() call. With this change, it is now required to fill all kNumSharedMemorySegments before starting to fill kMaxNumOfPendingBuffers. Bug: 795387 Change-Id: Ib297676316cd7f9cef529f27935ae5e1724f61eb Reviewed-on: https://chromium-review.googlesource.com/861053 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#529610} [modify] https://crrev.com/f5516e6184566b7594b97cbb0e53b4b45e7af337/content/renderer/media/gpu/rtc_video_decoder.cc [modify] https://crrev.com/f5516e6184566b7594b97cbb0e53b4b45e7af337/content/renderer/media/gpu/rtc_video_decoder.h [modify] https://crrev.com/f5516e6184566b7594b97cbb0e53b4b45e7af337/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
,
Jan 18 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sergeyu@chromium.org
, Dec 15 2017Owner: sergeyu@chromium.org
Status: Started (was: Untriaged)