New issue
Advanced search Search tips

Issue 795374 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix Timeout_Reboot Perf value for graphics_* tests

Project Member Reported by pwang@chromium.org, Dec 15 2017

Issue description

We have issue with Timeout_Reboot value for graphics_* tests reporting to chromeperf/.
The initial reason that we introduced this value is for reporting any Reboot happened during the test' run span. But as we observed in the past few months, the value is not working as intended. 
We should try to find a way to get the alert reported correctly.

[1] https://stainless.corp.google.com/search?exclude_retried=true&first_date=20171001&master_builder_name=&builder_name_number=&shard=&exclude_acts=true&builder_name=&master_builder_name_number=&owner=&retry=&exclude_cts=false&exclude_non_production=true&hostname=&board=%5Eveyron_jerry%24&test=graphics_*&exclude_not_run=false&build=%5ER64%5C-10176%5C.2%5C.0%24&status=FAIL&status=ERROR&status=ABORT&reason=pingable&waterfall=&suite=&last_date=20171215&exclude_non_release=false&exclude_au=true&view=list
[2] crbug.com/774348
 

Comment 1 by ihf@chromium.org, Dec 16 2017

Components: OS>Kernel>Graphics
Labels: M-65 OS-Chrome
It doesn't seem as reliable as it should. And your example for instance was not. But there are instances where it got detected, like here
https://chromeperf.appspot.com/report?sid=b9ec43d3eca46322fc2b16f86aecfe84de6be6ab9215c27ce2d4958cf771c810&start_rev=31380000967600000&end_rev=32950001021800000

It is possible that things are collected during timeout but not reboot. I think reboot often does not collect data (a reboot may also completely lose files that are only in RAM), but the job after collects some data (which might be useless, as we don't connect both).

I am ok if we think of alternative ways to fix this. We do need alerts in case of reboot/hangs.

Comment 2 by pwang@chromium.org, Dec 18 2017

Yeah. Will wait and not delete the value until we have a more rebust way to report this. 
Status: Assigned (was: Untriaged)

Sign in to add a comment