New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795363 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 763752
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

devtools crashed - websocket closed

Reported by misha199...@mail.ru, Dec 15 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. -> open devtools
2. -> Sources
3. ->  open a file with 4 000 000 lines
4. -> devtools closed 

What is the expected behavior?

loading and debugging a script

What went wrong?

closes the debugger when opening a file weighing 48 mb with 4,000,000 lines

Did this work before? Yes 63.0.3239.84

Chrome version: 63.0.3239.84  Channel: stable
OS Version: Windows 7
Flash Version: 

You can split the script conditionally into several scripts if the number of rows exceeds the maximum allowed https://stackoverflow.com/questions/16637530/whats-the-maximum-pixel-value-of-css-width-and-height-properties
 
Are you using remote debugging? Why do you mention websocket?

Comment 2 by misha199...@mail.ru, Dec 16 2017

if there are too many rows
2017-12-16_11-05-32.png
294 KB View Download

Comment 3 by misha199...@mail.ru, Dec 16 2017

2017-12-16_11-13-02.png
282 KB View Download

Comment 4 by misha199...@mail.ru, Dec 16 2017

in a compiled browser, both debuggers close when the file is opened.
https://www.google.ru/chrome/browser/canary.html
2017-12-16_11-18-51.png
257 KB View Download
Labels: Needs-Triage-M63
Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
Reporter@ - Thanks for filing the issue...!!

Could you please provide a sample webpage/test file to test the issue from TE-end.
This will help us in triaging the issue further.

Thanks...!!
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by misha199...@mail.ru, Dec 18 2017

1. Limit the number of pixels in all browsers, it is better to align the scroll bar to line numbers.
2. If you insert large code into the console, the browser closes
Labels: -Pri-2 hasbisect-per-revision ReleaseBlock-Stable M-64 OS-Linux OS-Mac Pri-1
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.12.6 and Ubuntu 14.04 using chrome beta version #64.0.3282.24 and latest canary #65.0.3298.3. But the issue is not reproducible on reported version #63.0.3239.84

Bisect Information:
=====================
Good build: 64.0.3269.0    Revision(516552)
Bad Build : 64.0.3270.0    Revision(516942)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/16b84d67c1349f534233cecefc332cf94387542a..792e482212d3eace2f24a1975a339bbdc73d1973

From the above change log suspecting below change
Change-Id: I1a0e18748db9247947444a0cd0b8fa9233152cbd
Reviewed-on: https://chromium-review.googlesource.com/754511

einbinder@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!
Owner: kozy@chromium.org
The patch in question expanded the JavaScript compiler feature to more kinds of files, so that's probably why it showed up from the bisect.

We don't need to be compiling 48mb files, but it is interesting that it crashes. @kozy any thoughts?
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/459a4d3aa0dd725e3edd1b85740017c59b65aea3

commit 459a4d3aa0dd725e3edd1b85740017c59b65aea3
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Dec 20 01:53:02 2017

DevTools: Dont compile large files

Compiling very large files (40mb) will crash DevTools

Bug:  795363 
Change-Id: I15108f3cc6b09daa3501782626dee734e3e3f049
Reviewed-on: https://chromium-review.googlesource.com/835416
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525221}
[modify] https://crrev.com/459a4d3aa0dd725e3edd1b85740017c59b65aea3/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompilerPlugin.js

Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest chrome version #65.0.3309.0 as per the comment #0 and #7.
Attaching screen cast for reference.
Observed that loading and debugging a large script happened without any crash.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
795363.mp4
2.6 MB View Download
Cc: abdulsyed@chromium.org
einbinder@, seems like we need to merge the above fix (c#12) to M64 branch: 3282 if it's really safe?
einbinder@/kozy@, can you please comment on c#14?
kozy@ Ping! This issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue?

Thanks!

Comment 17 by kozy@chromium.org, Jan 22 2018

Labels: Merge-Request-64
We should merge @einbinder's CL.
Project Member

Comment 18 by sheriffbot@chromium.org, Jan 22 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 22 2018

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfba45ece8919a12d5aa1a9eb010cebd9439d0e0

commit dfba45ece8919a12d5aa1a9eb010cebd9439d0e0
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jan 22 07:12:14 2018

DevTools: Dont compile large files

Compiling very large files (40mb) will crash DevTools

TBR=einbinder@chromium.org

(cherry picked from commit 459a4d3aa0dd725e3edd1b85740017c59b65aea3)

Bug:  795363 
Change-Id: I15108f3cc6b09daa3501782626dee734e3e3f049
Reviewed-on: https://chromium-review.googlesource.com/835416
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525221}
Reviewed-on: https://chromium-review.googlesource.com/877825
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#564}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/dfba45ece8919a12d5aa1a9eb010cebd9439d0e0/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompilerPlugin.js

Comment 20 by kozy@chromium.org, Jan 22 2018

Labels: -ReleaseBlock-Stable
I would like to check why inspector is crashing on attempt to compile 48 Mb script so I  will leave this issue open but removed release block stable since with fix we do not compile big scripts in DevTools any more.
Labels: -Merge-Review-64 Merge-Approved-64
Labels: -Merge-Approved-64
Cc: sc00335...@techmahindra.com
Labels: TE-Verified-M64 TE-Verified-64.0.3282.113
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest chrome beta version #64.0.3238.113.
Attaching screen cast for reference.
Observed that loading and adding breakpoints to a large script doesn't crash devtools.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
795363.mp4
2.6 MB View Download

Comment 24 by les...@gmail.com, Jun 20 2018

Still not working for files that are a little below 1048576 characters limit (it's crashing like before). I dont think this fix is acceptable. We should find core reason why It's crashing.
Mergedinto: 763752
Status: Duplicate (was: Assigned)

Sign in to add a comment