CL at https://chromium-review.googlesource.com/c/chromium/src/+/830651

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa5363838df3648bac4323d51d71b101d4e22a30

commit fa5363838df3648bac4323d51d71b101d4e22a30
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Dec 16 01:57:44 2017

[CR elements] inherit font family for cr-link-row

This CL fixes the font family when overriding a <button> element with
is="cr-link-row". <button> was defaulting to Arial. This CL will inherit
its parents font family, which for MD WebUI is Roboto (with some fallbacks).

Bug:  795362 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3303425f2dd2e10c95a7f30bf6b919ec7140d4be
Reviewed-on: https://chromium-review.googlesource.com/830651
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524560}
[modify] https://crrev.com/fa5363838df3648bac4323d51d71b101d4e22a30/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html

This merge request is because of how small and low risk this change is. It's not critical though, feel free to reject the request.

This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

dschuyler@,

As the above provided images are in chinese language, could you please help us to provide reproducible steps from TE end to verify this issue.

Thanks in advance..!

#10. I don't know how to read Chinese either :) I'm going by what scottchen@ tells me.

Though there's no need to read the language. This is a font-family change (like changing from Courier to Arial), the actual text itself is not changing. Scott has verified the 'expected' images in #0. My suggestion is to compare the images labeled expected and see if they look like they do on the screen. Another suggestion: try looking at the last line in each of the four images. Those give a good idea of how different the font style is.

Overall, if the current build looks like the pictures (especially the last line) in 'actual' then it's broken and if it looks like 'expected' then it's correct (at least per Scott, and I trust Scott).

Can also compare the english text, since the font also changed for English (even though the difference is less obvious). See attachments (before: Arial, after: Roboto).

Deleted: english_arial.png 2.2 KB

	english_arial.png 2.2 KB View Download

Deleted: english_roboto.png 1.8 KB

	english_roboto.png 1.8 KB View Download

small very low risk change. Approving merge to M64. Branch:3282

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d62dfd25300c59a81a11b8f08d5465d3c22e1fd

commit 4d62dfd25300c59a81a11b8f08d5465d3c22e1fd
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Mon Dec 18 21:26:03 2017

[CR elements] inherit font family for cr-link-row

This CL fixes the font family when overriding a <button> element with
is="cr-link-row". <button> was defaulting to Arial. This CL will inherit
its parents font family, which for MD WebUI is Roboto (with some fallbacks).

Bug:  795362 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3303425f2dd2e10c95a7f30bf6b919ec7140d4be
Reviewed-on: https://chromium-review.googlesource.com/830651
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524560}(cherry picked from commit fa5363838df3648bac4323d51d71b101d4e22a30)
Reviewed-on: https://chromium-review.googlesource.com/833130
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#274}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/4d62dfd25300c59a81a11b8f08d5465d3c22e1fd/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html

 Issue 781681  has been merged into this issue.

 Issue 803145  has been merged into this issue.