New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795329 link

Starred by 1 user
Status: Fixed
Owner:
█ fjhenigman@chromium.org
Last visit 16 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue angleproject:1569



Sign in to add a comment

gypi_to_gn should skip target_defaults

Project Member Reported by fjhenigman@chromium.org, Dec 15 2017 
gypi_to_gn dies on any input file that has a 'target_defaults' section with the message "Attempting to recursively print a dictionary."
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1d7d41d5aec7d6562f94544675f90eb4e915f44

commit f1d7d41d5aec7d6562f94544675f90eb4e915f44
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Fri Dec 15 20:19:18 2017

Make gypi_to_gn skip target_defaults sections.

Add 'target_defaults' to the list of top level keys ignored by gypi_to_gn.py
so it can process files that contain that.

BUG= 795329 

Change-Id: I3733a7efb97366827febf87ec1be95ad8723be23
Reviewed-on: https://chromium-review.googlesource.com/830114
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524449}
[modify] https://crrev.com/f1d7d41d5aec7d6562f94544675f90eb4e915f44/build/gypi_to_gn.py

Comment 2 by jmad...@chromium.org, Jan 4 2018 

Presumably this is fixed now?

Comment 3 by fjhenigman@chromium.org, Jan 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment