New issue
Advanced search Search tips

Issue 795326 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"RenderFrameHostImplBrowserTest.IframeBeforeUnloadParentHang" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 15 2017

Issue description

"RenderFrameHostImplBrowserTest.IframeBeforeUnloadParentHang" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRgsSBUZsYWtlIjtSZW5kZXJGcmFtZUhvc3RJbXBsQnJvd3NlclRlc3QuSWZyYW1lQmVmb3JlVW5sb2FkUGFyZW50SGFuZww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
over to avi@.  Been hitting this on the CQ
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/217981

Comment 2 by kbr@chromium.org, Dec 15 2017

This is blocking the CQ.
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/218074

Please disable this test until it's fixed.

Comment 3 by kbr@chromium.org, Dec 16 2017

Disabling this test in https://chromium-review.googlesource.com/831127 .

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58bea862dd4cb8dcdd64be39a7a5cb3313d8f8bb

commit 58bea862dd4cb8dcdd64be39a7a5cb3313d8f8bb
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Dec 16 01:09:03 2017

Disable IframeBeforeUnloadParentHang on Linux TSAN.

Disabling this RenderFrameHostImplBrowserTest on this configuration as
it's frequently hanging and blocking the CQ.

BUG=795326
TBR=avi@chromium.org

Change-Id: I88e5b4158de3c92113b767b00b64d88e11ae09ca
Reviewed-on: https://chromium-review.googlesource.com/831127
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524544}
[modify] https://crrev.com/58bea862dd4cb8dcdd64be39a7a5cb3313d8f8bb/content/browser/frame_host/render_frame_host_impl_browsertest.cc

Comment 5 by kbr@chromium.org, Dec 16 2017

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Test's disabled on the flaky config; downgrade to P2, remove from sheriff queue.

Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Dec 16 2017

Labels: Sheriff-Chromium
Detected 28 new flakes for test/step "RenderFrameHostImplBrowserTest.IframeBeforeUnloadParentHang". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRgsSBUZsYWtlIjtSZW5kZXJGcmFtZUhvc3RJbXBsQnJvd3NlclRlc3QuSWZyYW1lQmVmb3JlVW5sb2FkUGFyZW50SGFuZww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
The test stopped failing after #4, removing Sheriff label

Sign in to add a comment