Abort button is there, but does not cancel build |
|||||||
Issue descriptionBuildbucket job page has Abort button, but it does not abort the build, as result we may have two running builds, which may or may not be bad. Please do "// TODO(vadimsh): Send the abort signal to buildbucket." in https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/scheduler/appengine/task/buildbucket/buildbucket.go?type=cs&q=%22Send+the+abort+signal+to+buildbucket.%22&sq=package:chromium&l=269&rcl=a3b63afc9807e8572c31a6b5412ce4b9f1bbec02 buildbucket cancel API: https://godoc.org/go.chromium.org/luci/common/api/buildbucket/buildbucket/v1#Service.Cancel alternatively, hide the button until this is fixed.
,
Dec 21 2017
,
May 19 2018
Issue 844788 has been merged into this issue.
,
May 19 2018
,
Jun 26 2018
I've been telling people to use this button for a while now, and I'm starting to migrate across builders which are unsafe if run in parallel, so this will become dangerous.
,
Jun 27 2018
,
Jun 27 2018
I've started a CL.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/273709e095507043c270206ce06d9183ef38595c commit 273709e095507043c270206ce06d9183ef38595c Author: Vadim Shtayura <vadimsh@chromium.org> Date: Thu Jun 28 01:56:36 2018 [scheduler] Propagate abort signal to Buildbucket. Also handle errors from AbortTask more carefully. It's the first time we have ANY implementation of AbortTask. R=tandrii@chromium.org BUG= 795316 Change-Id: I01ba9cb9bb0dd0c462d5fd9d98204c07debac2e3 Reviewed-on: https://chromium-review.googlesource.com/1116288 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/273709e095507043c270206ce06d9183ef38595c/scheduler/appengine/engine/engine.go [modify] https://crrev.com/273709e095507043c270206ce06d9183ef38595c/scheduler/appengine/engine/engine_test.go [modify] https://crrev.com/273709e095507043c270206ce06d9183ef38595c/scheduler/appengine/engine/helpers_test.go [modify] https://crrev.com/273709e095507043c270206ce06d9183ef38595c/scheduler/appengine/task/buildbucket/buildbucket.go [modify] https://crrev.com/273709e095507043c270206ce06d9183ef38595c/scheduler/appengine/task/buildbucket/buildbucket_test.go
,
Jun 28 2018
I'll deploy this tomorrow.
,
Jun 28 2018
Thanks for the quick fix!
,
Jun 29 2018
Aaaand... I forgot to deploy this today, and it is a bit late for deployments now. So I'll try not to forget about it tomorrow.
,
Jun 29 2018
Deployed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vadimsh@chromium.org
, Dec 15 2017