Issue metadata
Sign in to add a comment
|
Chromium build fails on libpng for mips64 when using msa optimizations
Reported by
djordje....@mips.com,
Dec 15 2017
|
||||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. fetch chromium code as per https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_instructions.md 2. gn gen out/Release --args=" mips_use_msa=true target_os=\"android\" target_cpu=\"mips64el\" mips_use_msa=true is_debug=false" 3. ninja -C out/Release system_webview_apk What is the expected behavior? Build should succeed. What went wrong? Build fails, because of missing mips directory in updated third_party/libpng Here is example run on our buildbot as a reference: http://www.rt-rk.com/mips-buildbot/builders/Release_build_mips64_msa_true/builds/80/steps/Build/logs/stdio Did this work before? Yes Chromium revision 507040 Chrome version: git trunk Channel: n/a OS Version: not important Flash Version: n/a I have attached a patch which fixes this build issue for us (added mips directory and updated .gn file).
,
Dec 15 2017
Posted change for review: crrev.com/c/830153
,
Dec 15 2017
,
Dec 18 2017
It looks like Chromium does not have a MIPS build on our test infrastructure. Should we? Otherwise it seems like we could easily re-break this. Can you explain to me how this worked before and was broken? revision 507040 (when the mips build worked, right?) points to https://chromium.googlesource.com/chromium/src/+/d69eef5d58164234fc155c05a7631f68af4ed2c3. The following commit (0dc539884fd4) reverts an update of libpng to 1.6.34, but the next libpng change relands the update (I believe without any changes - so it should be in the same state as revision 507040). Though there are some lines that affect MIPS, I don't see anything in the mips folder (e.g. as in crrev.com/c/830153) in any case.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9837159c0e6f8bcaebe4cf65d6b736669ddc5b commit 0e9837159c0e6f8bcaebe4cf65d6b736669ddc5b Author: Djordje Golubovic <djordje.golubovic@mips.com> Date: Tue Dec 19 20:25:53 2017 Build MIPS MSA optimizations in libpng Add the files which contain the optimizations, taken from upstream 1.6.34. Update BUILD.gn to compile them when appropriate. Prior to Chromium revision 507040, these optimizations were enabled with a separate patch. R=scroggo@chromium.org Bug: 795312 Change-Id: Ib6db512ccea3248498cf62e5a38cb55d64efbc0c Reviewed-on: https://chromium-review.googlesource.com/830153 Reviewed-by: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#525127} [modify] https://crrev.com/0e9837159c0e6f8bcaebe4cf65d6b736669ddc5b/third_party/libpng/BUILD.gn [add] https://crrev.com/0e9837159c0e6f8bcaebe4cf65d6b736669ddc5b/third_party/libpng/mips/filter_msa_intrinsics.c [add] https://crrev.com/0e9837159c0e6f8bcaebe4cf65d6b736669ddc5b/third_party/libpng/mips/mips_init.c
,
Dec 21 2017
This merge fixes our issue. Thanks for review and commit, Leon!
,
Dec 21 2017
You're welcome! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by djordje....@mips.com
, Dec 15 201735.1 KB
35.1 KB Download