Two finger touchscreen tap for context menu doesn't work in OOPIFs |
||||||
Issue descriptionChrome Version: 65.0.3296.0 What steps will reproduce the problem? (1) With a desktop/laptop device with a touchscreen, run chrome with --site-per-process (2) Visit http://csreis.github.io/tests/cross-site-iframe-simple.html (3) Two finger tap inside the OOPIF What is the expected result? The context menu should appear. What happens instead? The context menu does not appear.
,
Dec 15 2017
Confirmed on a Chromebook Pixel 2 running 62.0.3202.97. James or Kevin, can you find an owner and aim to get this fixed soon? Thanks!
,
Dec 15 2017
Updating summary, since this only applies to touchscreen taps and not trackpad taps. But this still seems important for tablet-like devices.
,
Dec 16 2017
So we make it into ContextMenuController::ShowContextMenu, but we're dropped because of the check for ContextMenuAllowedScope::IsContextMenuAllowed(). It looks like we're just missing a ContextMenuAllowedScope in |WebFrameWidgetImpl::HandleGestureEvent| like we have in WebViewImpl.
,
Dec 18 2017
Thanks for tracking that down!
,
Jan 9 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8c22f591392bea5213383662b51e35ba9d736df commit d8c22f591392bea5213383662b51e35ba9d736df Author: Kevin McNee <mcnee@chromium.org> Date: Thu Jan 11 20:47:21 2018 OOPIF: Allow context menu on two finger tap. In order for the ContextMenuController to show the context menu, we must have a ContextMenuAllowedScope. We are missing this in |WebFrameWidgetImpl::HandleGestureEvent|. Bug: 795300 Change-Id: I54f63ba594625171199cbf3213421ef2cefaa228 Reviewed-on: https://chromium-review.googlesource.com/850992 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#528746} [modify] https://crrev.com/d8c22f591392bea5213383662b51e35ba9d736df/chrome/browser/chrome_site_per_process_browsertest.cc [modify] https://crrev.com/d8c22f591392bea5213383662b51e35ba9d736df/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
,
Jan 12 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mcnee@chromium.org
, Dec 15 2017