New issue
Advanced search Search tips

Issue 795297 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: 2018-07-01
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue aomedia:1539

Blocking:
issue 28291



Sign in to add a comment

third_party/libaom fails licensecheck

Project Member Reported by johannko...@google.com, Dec 15 2017

Issue description

Similar  to https://bugs.chromium.org/p/chromium/issues/detail?id=98319

Current status:
$ tools/checklicenses/checklicenses.py --ignore-suppressions third_party/libaom

'third_party/libaom/source/config/aom_version.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/ia32/aom_dsp_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/ia32/av1_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/ia32/aom_scale_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/x64/aom_dsp_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/x64/av1_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/win/x64/aom_scale_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/ia32/aom_dsp_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/ia32/av1_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/ia32/aom_scale_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/generic/aom_dsp_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/generic/av1_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/generic/aom_scale_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/x64/aom_dsp_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/x64/av1_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/config/linux/x64/aom_scale_rtcd.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/aom_scale/aom_scale_rtcd.pl' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/vector/vector.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/vector/vector.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/fastfeat/fast_9.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/fastfeat/fast.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/fastfeat/nonmax.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/third_party/fastfeat/fast.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/tools/all_builds.py' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/tools/author_first_release.sh' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/tools/ftfy.sh' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/build/make/rtcd.pl' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/aom_dsp/aom_dsp_rtcd_defs.pl' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/encoder/x86/corner_match_sse4.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/encoder/hash_motion.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/daala_tx.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/laplace_tables.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/x86/selfguided_sse4.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/x86/av1_txfm1d_sse4.h' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/x86/av1_fwd_txfm1d_sse4.c' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/av1_rtcd_defs.pl' has non-whitelisted license 'UNKNOWN'
'third_party/libaom/source/libaom/av1/common/daala_tx.c' has non-whitelisted license 'UNKNOWN'

 
NextAction: 2018-02-01
Setting next action to February. libaom is currently a pre-release snapshot. I have some pending changes but don't plan on rolling to chromium until a proper release is prepared.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://aomedia.googlesource.com/aom/+/e0e87d2bfd3551e347a39a41c17d9b7a3b9353b0

commit e0e87d2bfd3551e347a39a41c17d9b7a3b9353b0
Author: Johann <johannkoenig@google.com>
Date: Fri Dec 15 20:04:55 2017

mark generated version header

Allows it to pass the license check in chromium.

Cherry picked from libvpx fe4de1f

BUG=chromium:795297

Change-Id: Iebd13f606d61274d185aed075bebd80af5a99f09

[modify] https://crrev.com/e0e87d2bfd3551e347a39a41c17d9b7a3b9353b0/build/make/version.sh

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://aomedia.googlesource.com/aom/+/368c51acad7bda3df7df229617a37ddaeb313bc4

commit 368c51acad7bda3df7df229617a37ddaeb313bc4
Author: Johann <johannkoenig@google.com>
Date: Fri Dec 15 20:04:55 2017

mark generated rtcd headers

Allows them to pass the license check in chromium.

Cherry picked from libvpx 05e6e9a

BUG=chromium:795297

Change-Id: I81c92ae5d6bad2fdbfa17e8cab09f2bdb6fb84d2

[modify] https://crrev.com/368c51acad7bda3df7df229617a37ddaeb313bc4/build/make/rtcd.pl

The NextAction date has arrived: 2018-02-01
NextAction: 2018-06-01
The NextAction date is printed above in yyyy-mm-dd but the box to enter it below is mm-dd-yyyy. Weird.

This is low priority and we still don't have a finalized bitstream. Hopefully by June things have quieted down a little and I can clean this up.
The NextAction date has arrived: 2018-06-01
NextAction: 2018-07-01
Bitstream still not finalized
Blockedon: aomedia:1539
The NextAction date has arrived: 2018-07-01
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://aomedia.googlesource.com/aom/+/1739154fb81f161fbbd7717fba7865e82908d325

commit 1739154fb81f161fbbd7717fba7865e82908d325
Author: Johann <johannkoenig@google.com>
Date: Tue Jul 10 16:13:05 2018

cmake-format: annotate .cmake_format.py

Clears chromium checklicenses.py

BUG=chromium:795297

Change-Id: Id4c46a313cce01cdea77b2097d94f389c8fd3f65

[modify] https://crrev.com/1739154fb81f161fbbd7717fba7865e82908d325/.cmake-format.py

johannkoenig@, anything left on this or can we close?
Lots of stuff left on this.

Sign in to add a comment