New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795296 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Page Unresponsive dialog lists crashed pages

Project Member Reported by sh...@chromium.org, Dec 15 2017

Issue description

Chrome Version: 64.0.3282.14
OS: OSX 10.12.6

Background: I have a lot of tabs.

Periodically, I'll get a hung page and the "Page Unresponsive" dialog pops up, as seen in attached PU1, which shows 5 pages.  Depending on what's up, I'll click "Exit Page", then Reload the page I'm actually interested in.

Just now, I noticed that when I reloaded Facebook, soon enough it was hung again, and I got attached PU2 - which shows the exact same pages as before.  As far as I'm aware, these are all separate pages.

Next time, it happened after I had opened a tab, and now I had PU3, which includes the additional tab.

Doing a diff on `ps aux` output before and after, a process is getting killed.  So Chrome is ... rebuilding all of those tabs in the background when I refresh a single tab?  This doesn't seem likely to be correct operation.
 
PU1.png
50.9 KB View Download
PU2.png
50.9 KB View Download
PU3.png
58.3 KB View Download

Comment 1 by sdy@chromium.org, Jan 9 2018

Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
[Mac triage]

Comment 2 by sdy@chromium.org, Jan 9 2018

Labels: -Pri-3 Pri-2

Comment 3 by a...@chromium.org, Jan 9 2018

What's happening is that when you kill a process, the pages assigned to that process don't change. When you reload the page and it hangs again, the hung page dialogs searches across all tabs to see which are assigned to that hung process, not considering if those tabs are actually alive.

This should be a small check in the UI. Those crashed tabs aren't actually alive.

Comment 4 by a...@chromium.org, Jan 9 2018

Summary: Page Unresponsive dialog lists crashed pages (was: Reload after Page Unresponsive dialog reloads all the pages.)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bdab7b9c09926abc2921af8c70785e822da4787

commit 8bdab7b9c09926abc2921af8c70785e822da4787
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 09 22:09:31 2018

Don't list crashed tabs in the "Hung Page" dialog.

BUG= 795296 

Change-Id: I7f4667a4a4ec78a3dc605e56b8bb9a1bf92c5a4a
Reviewed-on: https://chromium-review.googlesource.com/857424
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528135}
[modify] https://crrev.com/8bdab7b9c09926abc2921af8c70785e822da4787/chrome/browser/ui/cocoa/hung_renderer_controller.mm
[modify] https://crrev.com/8bdab7b9c09926abc2921af8c70785e822da4787/chrome/browser/ui/views/hung_renderer_view.cc

Comment 6 by a...@chromium.org, Jan 10 2018

Status: Fixed (was: Assigned)
Cc: sandeepkumars@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on the reported version as per the steps mentioned in comment #0. Hence requesting reporter to confirm about the fix

shess@ Could you please check this issue in latest Canary and update the behavior.

Thanks!!

Sign in to add a comment