Pressing app button should be no-op on WebVR app from PWA "Add to Home screen" link |
||||||
Issue descriptionChrome Version: 64.0.3282.29 OS: Android N VrCore: 1.12.177372015 Device: Pixel *Logging this bug per discussion over chat with team. What steps will reproduce the problem? (1) On WebVR page in Chrome e.g https://webvr.info/samples/03-vr-presentation.html (2) open Chrome menu and tap "add to homescreen" (3) close Chrome (4) click link to WebVR presentation on homescreen (5) Enter WebVR presentation (Daydream headset) (6) Press app button on controller What is the expected result? no-op. Nothing should happen. What happens instead? They are taken to the DOFF screen. Prompted to remove the device from the headset. If the select the back button on the DOFF screen, they are briefly taken back to WebVR before automatically being returned to the DOFF.
,
Jan 17 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27cfcb83bc18193a085507f05a49df70b65ee664 commit 27cfcb83bc18193a085507f05a49df70b65ee664 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Jan 17 17:59:52 2018 VR: Fix app button exiting presentation in WebApps and CCTs We were incorrectly detecting when browsing mode was disabled on WebApps and CCTs. The test failed to detect this because of the DOFF flow not exiting WebVR presentation until it completes. Bug: 795293 Change-Id: I5fce6b3886f0728984d6d28560a6ae235714f0d7 Reviewed-on: https://chromium-review.googlesource.com/868247 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#529800} [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestFramework.java [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java [modify] https://crrev.com/27cfcb83bc18193a085507f05a49df70b65ee664/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java
,
Jan 17 2018
,
Feb 7 2018
,
Feb 14 2018
Added test case "App Button disabled in WebVR" to "WebVR Manual Testing Plan" to cover the App Button non-functionality. Other buttons are used during normal testing but there were no cases specifically calling out this button.
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by klausw@chromium.org
, Jan 9 2018Status: Available (was: Untriaged)