New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795252 link

Starred by 3 users

Regression: Unable to select cells on google sheets and page jumps on scrolling

Project Member Reported by sc00335...@techmahindra.com, Dec 15 2017

Issue description

Chrome Version: 65.0.3295.0 
OS: Mac 10.13.1

What steps will reproduce the problem?
(1)Sign into google sheets and scroll the page and observe
(2)After scroll select any of cell and observe

Expected: No jump should be seen while scrolling and should be able to select cells.

Actual: Instead page jumps and unable to select cells correctly[focus of selecting cell is not proper]

This is a regression issue as it is working fine in 65.0.3293.0 canary
 
Cc: gov...@chromium.org krajshree@chromium.org
Components: Blink>Scroll
Labels: ReleaseBlock-Dev Hotlist-GoogleApps OS-Mac
sheets_scroll.webm
12.4 MB View Download
Components: Platform>Apps
Labels: -ReleaseBlock-Dev -Needs-Bisect hasbisect-per-revision ReleaseBlock-Beta
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Issue is not seen in Linux and Windows

Good build : 65.0.3294.5 (Revision : 523977)
Bad build : 65.0.3295.0 (Revision : 524284)

You are probably looking for a change made after 524203 (known good), but no later than 524204 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/1e920b32c7c3000523870464e0a8954a0474790e..2e4a432454ac3f04d6c5fa8f17c49ce3026217d6

Reviewed-on: https://chromium-review.googlesource.com/820251

Suspecting same from changelog.

@junov :Please confirm the issue and help in re-assigning if it is not related to your change.
Cc: msrchandra@chromium.org junov@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 795255  has been merged into this issue.
Labels: -Pri-1 -ReleaseBlock-Beta ReleaseBlock-Dev Pri-0
Increasing the priority and blocker as we have tomorrow Dev release..  

Comment 5 by gov...@chromium.org, Dec 18 2017

Cc: abdulsyed@chromium.org ligim...@chromium.org
Justin, could you please revert the patch in the bisect if its the correct suspect. 

We are planning a Dev RC today.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fd548f2cf9a3585e82d800cfc40167a48bb582

commit c1fd548f2cf9a3585e82d800cfc40167a48bb582
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 19 00:55:31 2017

Fix canvas flickering and broken updates on Mac

CanvasResource_GpuMemoryBuffer was not refreshing its
sync token when new content was added, resulting in recycled
buffers never getting their contents flushed.

BUG= 795635 ,  795252 
TBR=xlai@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77a9e2cdba1397a664eda1e46d9126b1e2c8114d
Reviewed-on: https://chromium-review.googlesource.com/832350
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524888}
[modify] https://crrev.com/c1fd548f2cf9a3585e82d800cfc40167a48bb582/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/c1fd548f2cf9a3585e82d800cfc40167a48bb582/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19 2017

Labels: merge-merged-3298
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59620135abb6dc7802569b3a8a7214d19657c2b1

commit 59620135abb6dc7802569b3a8a7214d19657c2b1
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 19 01:00:21 2017

Fix canvas flickering and broken updates on Mac

CanvasResource_GpuMemoryBuffer was not refreshing its
sync token when new content was added, resulting in recycled
buffers never getting their contents flushed.

BUG= 795635 ,  795252 
TBR=junov@chromium.org, xlai@chromium.org
NOTRY=true

(cherry picked from commit c1fd548f2cf9a3585e82d800cfc40167a48bb582)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77a9e2cdba1397a664eda1e46d9126b1e2c8114d
Reviewed-on: https://chromium-review.googlesource.com/832350
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524888}
Reviewed-on: https://chromium-review.googlesource.com/833069
Cr-Commit-Position: refs/branch-heads/3298@{#4}
Cr-Branched-From: 6586a208880a70a00856529493741971ecfea5c2-refs/heads/master@{#524617}
[modify] https://crrev.com/59620135abb6dc7802569b3a8a7214d19657c2b1/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/59620135abb6dc7802569b3a8a7214d19657c2b1/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Comment 9 by junov@chromium.org, Dec 19 2017

I hastily landed and merged a quick fix in order to unblock the dev channel release. A proper CL (duly reviewed, with tests) will go into trunk in coming days.  

I am going to keep this bug open until the work is complete, but we can consider Dev release unblocked at this point.
Labels: TE-Verified-M65 TE-Verified-65.0.3299.0
Verified the fix on Mac 10.13.1 using Chrome dev version #65.0.3299.0 with steps mentioned in comment #0. Attaching screen cast for reference.

No Flickering of contents is seen on scrolling and able to select particular cell successfully. Hence, the fix is working as expected.

Adding the verified labels.
795252.mp4
1.3 MB View Download
Labels: TE-Verified-65.0.3298.3
Issue is no longer reproducible on 65.0.3298.3 dev as well. Hence adding TE-Verified-65.0.3298.3
Status: Verified (was: Assigned)

Comment 13 by ajha@chromium.org, Jan 9 2018

Labels: RegressedIn-65 Target-65 FoundIn-65
Labels: -Hotlist-GoogleApps Hotlist-Partner-GSuite

Sign in to add a comment