New issue
Advanced search Search tips

Issue 795250 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 15 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grunell@google.com

virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html  webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Started with:
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65206
 
Labels: OS-Windows Type-Bug
Owner: rbyers@chromium.org
Status: Assigned (was: Available)
Assigning to rbyers@ since you reviewed the addition of this test.
Cc: rbyers@chromium.org
Components: Blink>Input
Owner: ----
Status: Untriaged (was: Assigned)
rbyers@ is ooo, letting Blink>Input triage this.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4fcf1250529363c7aac2dde04d77c285b7a10c9

commit f4fcf1250529363c7aac2dde04d77c285b7a10c9
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri Dec 15 12:51:31 2017

Update test expectations for failing virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html on Win7.

TBR= rbyers@chromium.org

Bug:  795250 
Change-Id: I1af8aadac484d5c03fa352aecd133e7cba5de868
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/829140
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524367}
[modify] https://crrev.com/f4fcf1250529363c7aac2dde04d77c285b7a10c9/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by mek@chromium.org, Dec 22 2017

virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html is now aso failing, not sure if it's related, seems to have started in https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65359
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b88aa83829998029cbd0030af9d1e1f75b4828

commit 58b88aa83829998029cbd0030af9d1e1f75b4828
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Dec 22 21:24:30 2017

Update test expectation for virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html

TBR=rbyers@chromium.org

Bug:  795250 
Change-Id: If5f6df738c35c1ee7920f83f1ebc2771a4f06dac
Reviewed-on: https://chromium-review.googlesource.com/843008
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526064}
[modify] https://crrev.com/58b88aa83829998029cbd0030af9d1e1f75b4828/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdb1b395e8cbc55e5fb9e7399aaa7818933b42d7

commit fdb1b395e8cbc55e5fb9e7399aaa7818933b42d7
Author: Sheriff-o-matic <sheriff-o-matic@appspot.gserviceaccount.com>
Date: Tue Jan 02 17:52:10 2018

update virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html expecations

Bug:  795250 
Change-Id: I1f66094298e9019ef2a04526f9ba772148903d20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/846533
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526501}
[modify] https://crrev.com/fdb1b395e8cbc55e5fb9e7399aaa7818933b42d7/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by bokan@chromium.org, Jan 4 2018

Cc: bokan@chromium.org
Owner: nzolghadr@chromium.org
Status: Assigned (was: Untriaged)
Flakiness dashboard shows the test passing on Linux now but still failing on Windows bots. Seems to be passing for me locally on Linux.

Navid, since this has to do with hover, could you please triage
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e286250b9e5c11b0a9e14d6b243dc206999c4a50

commit e286250b9e5c11b0a9e14d6b243dc206999c4a50
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 05 00:42:57 2018

Update TestExpectations with update-flaky-expectations

This CL was initially based on changes made by the third_party/WebKit/Tools/Scripts/update-flaky-expectations, but includes manual changes as well, including formatting changes and making expectations more specific based on visually checking the flakiness dashboard results.

Flakiness dashboard link:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http/tests/devtools/coverage/coverage-view.js,inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang.js,http/tests/websocket/close-code-and-reason.html,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-001.xht,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-002.xht,external/wpt/css/css-fonts/font-display/font-display.html,fast/workers/chromium/worker-document-leak.html,fast/dom/Window/window-resize-contents.html,fast/text/ellipsis-in-relative-inline.html,fast/spatial-navigation/snav-1st-stop.html,fast/spatial-navigation/snav-display-contents-crash.html,fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html,fast/spatial-navigation/snav-div-in-anchor.html,fast/spatial-navigation/snav-hidden-focusable-element.html,fast/spatial-navigation/snav-iframe-nested.html,fast/spatial-navigation/snav-iframe-no-focusable-content.html,fast/spatial-navigation/snav-iframe-no-scrollable-content.html,fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html,fast/spatial-navigation/snav-media-elements.html,fast/spatial-navigation/snav-multiple-select-focusring.html,fast/spatial-navigation/snav-offscreen-content.html,fast/spatial-navigation/snav-only-clipped-overflow-content.html,fast/spatial-navigation/snav-simple-content-overflow.html,fast/spatial-navigation/snav-single-select-list.html,fast/spatial-navigation/snav-zero-margin-content.html,external/wpt/clear-site-data/storage.https.html,http/tests/devtools/network/network-xhr-same-url-as-main-resource.js,virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html

Bug:  518989 ,  520737 , 520739,  564109 ,  729836 ,  731535 ,  746904 , 757165, 767040,  767269 ,  773353 ,  785980 ,  795250 
Change-Id: I03ac7e658ee42ccf3798e7f3994d30fc74880565
Reviewed-on: https://chromium-review.googlesource.com/847835
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527171}
[modify] https://crrev.com/e286250b9e5c11b0a9e14d6b243dc206999c4a50/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548c71e058f220820630dfcaa307f8462bbc4645

commit 548c71e058f220820630dfcaa307f8462bbc4645
Author: Ella Ge <eirage@chromium.org>
Date: Thu Feb 08 00:14:26 2018

Set cursor visibility in gesture-tap-hover test.

GestureEvents hover states layout tests flaky because fake mouse
move was fired between two tap. Set cursor invisible to prevent
fake events firing.

Bug:  806748 , 795250 
Change-Id: I81859362a1eb80810e875fd9d513689eaa3f0843
Reviewed-on: https://chromium-review.googlesource.com/898005
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535205}
[modify] https://crrev.com/548c71e058f220820630dfcaa307f8462bbc4645/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/548c71e058f220820630dfcaa307f8462bbc4645/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/548c71e058f220820630dfcaa307f8462bbc4645/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html

Status: Fixed (was: Assigned)

Sign in to add a comment