New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795237 link

Starred by 2 users
Status: Fixed
Owner:
wzang@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Submit' button is seen enabled without entering password in Lock Screen

Project Member Reported by mmanchala@chromium.org, Dec 15 2017 
Chrome Version: 65.0.3294.0/10216.0.0 Candy,Minnie and Celes
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> click on Uber Tray and select 'Lock' option
(2)Now in Lock screen observe 'Submit' button is enabled without entering password for User(Please refer Video and Screenshot)

Note:Click on Submit button without entering password for User and observe 'Sorry your password..." error message is seen

Expected: 'Submit' button should be enabled after entering password for User
Actual: Instead 'Submit' button is seen enabled without entering password 

This is Regression Issue as same is working fine in 63.0.3239.86/10032.71.1  Candy
Actual_EnabledSubmitButton.mp4
10.6 MB View Download
Actual_EnabledSubmitButton.jpg
540 KB View Download
Expected_DisabledSubmitButton.mp4
7.5 MB View Download
Expected_DisabledSubmitButton.jpg
501 KB View Download

Comment 1 by mmanchala@chromium.org, Dec 19 2017

Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)
@wzang: Please confirm the issue

Comment 2 by wzang@chromium.org, Dec 21 2017

Cc: jdufault@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61be25d1b7c197899d4a4097c1a8561f70e07dd

commit c61be25d1b7c197899d4a4097c1a8561f70e07dd
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jan 04 01:02:18 2018

cros: Make sure the submit button state is initialized correctly

Fixes a regression since [1]. Prior to that |LoginPasswordView| relied
on |LoginAuthUserView| to call Clear() to initialize the states. Now
the initialization is moved to the ctor of the password view.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/688734

Bug:  795237 
Change-Id: I80892ad097a4f0152230921c8b264a9777e9e62e
Reviewed-on: https://chromium-review.googlesource.com/845319
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526876}
[modify] https://crrev.com/c61be25d1b7c197899d4a4097c1a8561f70e07dd/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/c61be25d1b7c197899d4a4097c1a8561f70e07dd/ash/login/ui/login_password_view_test.cc

Comment 4 by wzang@chromium.org, Jan 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment