New issue
Advanced search Search tips

Issue 795229 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 784319
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webpage_replay_go_server.py record doesn't work.

Project Member Reported by mattcary@chromium.org, Dec 15 2017

Issue description

Seems to be a simple flag-processing problem, see crrev.com/c/828975.

The fact that it's such a basic error suggests that recording is unmaintained for webpage_replay_go_server.py. 

Looking through recent changes, it seems that telemetry/record_wpr.py is used instead for recording. That script is used only the context of PageTests, however, making it unsuitable for stand-alone use, for example with tools/android/customtabs_benchmark.

So, before proceeding with the above-mentioned patch to fix webpage_replay_go_server, I guess the question is if it's even worth trying to get that script to work stand-alone, or if it would be better to re-invent a wpr wrapper script.
 
tools/perf/record_wpr is the script we typically use for recording. Also telemetry/record_wpr.py do rely on webpage_replay_go_server.py. 

What command did you run to reproduce this bug?

Cc: pasko@chromium.org
Components: Speed>Benchmarks
Actually I think the higher level question to ask is what is  tools/android/customtabs_benchmark? :-)

Our tech stack around webpage_replay_go_server is not meant to be usable publicly, and it's better if you can work with us to build tools/android/customtabs_benchmark using Telemetry's benchmarking framework.
Yes, exactly. We last used that script with the python wpr server, and now we're starting to look into that again.

This script does benchmarking for CCT features like prefetching, warmup, etc. It does it by launching a native chrome app that only launches a browser via a CCT intent. Hence, it's not clear how to put it into the telemetry framework; I guess the CCT stub app would be a new kind of Browser(), but it's a very limited and special one. The telemetry architecture is a little opaque to outsiders :)

Any suggestions welcome...
Are you aware of Pasko effort to rewrite Telemetry startup benchmark to be more generic & cover cases like CCT? I think this case should also go under that unified clank startup benchmark.

https://docs.google.com/document/d/1sWsM9jt8mrWiN5ngfhVSgfHg2E_Kjls71dhYFI011rg/edit?disco=AAAABakPknk&ts=5a003cb6
Cc: mattcary@chromium.org
Yes, he convinced me to help him with that :)

The easy first step was to get the customtabs benchmark updated from the old WPR server. Given that that now seems not interesting, my previous question holds: there seems to be a need for a new kind of Browser() to handle the CCT launcher app, but we need guidance in how to implement that.
Cc: perezju@chromium.org
Matt: Juan is already started working on this (tracking bug:  issue 784319 ). The idea is we gonna add an API in telemetry that allows it to extracts all the Chrome browsers on the system instead of create a new kind of Browser(). Code would look s.t like this:

android_platform.LaunchApp('twitter')
android_platform.Tap('id=....')  # -> this triggers CCT
android_platform.WaitFor('id=...')  # Wait for CCT to appear on the screen
alive_browsers = android_platform.GetAllRunningBrowserInstances()
assert len(alive_browsers) == 1
cct_browser = alive_browser[0]
... Do the rest of the user interaction with cct_browser ...
Mergedinto: 784319
Status: Duplicate (was: Untriaged)
OK, cool. So this is really the same work. Thanks for the clarification.

Marking as dup.

Sign in to add a comment