New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795228 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Nothing happens after clicking on ’New File’ in sources section of dev tools

Reported by pranjali...@etouch.net, Dec 15 2017

Issue description

Chrome Version:65.0.3294.5 (Official Build) 682d479193fcc856b8a99b7250773802b3f631ff-refs/branch-heads/3294@{#7} 

OS:Win(7,8,10),Mac(10.12.6,10.13.2),Linux(14.04 LTS)

Steps to reproduce:
1.Launch Chrome and open dev tools on NTP.
2.Go to Sources section and select File System tab.
3.Add folder by clicking on '+ Add folder to workspace’,Right click on added folder and click ‘New File’ option.
4.Observe.

Actual Result:Nothing happens after clicking on ’New File’ in sources section.
Expected Result:New file should be added in folder.

This is a regression issue, broken in M-64 series, Using the per-revision bisect providing the bisect results,

Good Build:64.0.3268.0
Bad Build:64.0.3269.0

You are probably looking for a change made after 516211 (known good), but no later than 516212 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/e45a8dbba0aedb381a82baa0cba214d90b767dcc..ca1cdc21859079f747ba05ca10db25113001e825

allada@:Kindly help to reassign, if your changes are not related to this issue.
 
Actual_result.mov
3.6 MB Download
Expected_result.mov
4.2 MB Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Owner: einbinder@chromium.org
Still we are able to reproduce the issue on Windows,Mac & Linux as per C#0. 
einbinder@,Could you please take a look as it is marked as stable blocker.
Thanks..!
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d1ea6395eb0a90b19b2e7af2d26619adf7eee6

commit 85d1ea6395eb0a90b19b2e7af2d26619adf7eee6
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 10 21:33:21 2018

DevTools: Fix creating new files on root folders

Bug:  795228 
Change-Id: I87498d7a511f7a40640591462ad79a582c3e190a
Reviewed-on: https://chromium-review.googlesource.com/857746
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528430}
[modify] https://crrev.com/85d1ea6395eb0a90b19b2e7af2d26619adf7eee6/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Comment 5 by vku...@etouch.net, Jan 11 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3318.0
Update : 
Verified this issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3) OS with latest Canary build #65.0.3318.0 and the issue is fixed.
Kindly review an attached screen-cast.

Thank You!

Actual_Canary.mov
2.5 MB Download
einbinder@ If this issue is fixed completely could you please change the status of the bug.

Thanks!
Friendly ping to get an update on this issue as per C#6.
Thanks..!
einbinder@, 
Gentle ping!
please mark it as 'Fixed' if there is no other pending CL exists.
Thanks..!

Comment 9 by gov...@chromium.org, Feb 13 2018

M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge  into the release branch ASAP. Thank you.
Gentle ping to get an update on this issue as it is marked as stable blocker for M65.

Thanks..!
M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Merge has to happen latest by 4:00 PM PT Monday (02/26/18) in order to make it to last M65 beta release next week. Thank you.
Per comments #4 and #5, this is fixed in M65. If nothing is pending, pls mark the bug as fixed. Thank you.
Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
No merge needed to M65. So removing "Merge-TBD" label.

Sign in to add a comment