New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Copies count doesn't decreases according to click on print preview page.

Reported by dchau...@etouch.net, Dec 15 2017

Issue description

Chrome Version: 65.0.3294.5 (Official Build) 682d479193fcc856b8a99b7250773802b3f631ff-refs/branch-heads/3294@{#7} 32/64-bit.
OS: Windows(7,8,10).

What steps will reproduce the problem?
1. Launch chrome, go to NTP and give print command.
2. Enter number 20 or any number in 'Copies' text-box.
3. Now multiple times click on down arrow to decrease the copies count and observe.

Copies count doesn't decreases as per click.
Copies count should decrease as per click.

NOTE: 
1. This issue is also seen in 'Scale' text-box.
2. This issue is not seen on Mac and Linux OS.

This is a Windows specific regression issue, broken in M-65 series, below is manual regression range.

Good build: 65.0.3293.0
Bad build: 65.0.3294.0

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
980 KB View Download

Comment 1 by dchau...@etouch.net, Dec 15 2017

Labels: hasbisect
Owner: chaopeng@chromium.org
Status: Assigned (was: Unconfirmed)
NOTE: Unable to provide bisect using bisect-per-revision script as tab is getting crashed after launching the Chrome builds from tool. Hence providing bisect using old script.

You are probably looking for a change made after 523680 (known good), but no later than 523691 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/48b444dd6b57a1937ffe86f3a1399fdd2adae254..537399fd2bf3faa258c7b2c4f526681ed8f4a4b3

Suspect: https://chromium.googlesource.com/chromium/src/+/12dca8659ca7a447e813d0d25f930cf7932b87fd

@chaopeng: Kindly help to reassign, if your changes are not related to this issue.
Labels: ReleaseBlock-Beta
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Labels: -ReleaseBlock-Beta
Confirmed this issue is from my CL. reverting.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe75f56318e0e3c2f29ee0a1156c85f83dfad2e

commit ffe75f56318e0e3c2f29ee0a1156c85f83dfad2e
Author: Jianpeng Chao <chaopeng@chromium.org>
Date: Fri Dec 15 19:22:35 2017

Revert "Fix Windows touchpad lagging in first tab"

This reverts commit 12dca8659ca7a447e813d0d25f930cf7932b87fd.

Reason for revert:  crbug.com/795223 

Original change's description:
> Fix Windows touchpad lagging in first tab
>
> Currently the receiving of WM_MOUSEWHEEL messages lags when we open a
> URL on a new window until we resize. The issue was introduced by
> r384698. That CL change wait for MOUSE_EVENT to wait for SENDMESSAGE
> in MessagePumpForUI::WaitForWork to optimize the GPU thread. But the
> GPU thread does not use MessagePumpForUI anymore so it should be OK to
> just remove that code.
>
> The updated version of Chrome was tested to make sure that the hangs
> that were occasionally seen when using chrome://tracing are still gone.
>
> After this CL chaopeng@ need to monitor to make sure that the crash
> rate not increase.
>
> Bug:  713907 , 596190
> Change-Id: I7545a867de4851acd4e57c9b8c7a3dd05def1dd8
> Reviewed-on: https://chromium-review.googlesource.com/809829
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523689}

TBR=thestig@chromium.org,brucedawson@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  713907 , 596190,  795223 
Change-Id: I3f53fd77e7a6545cd214444cac46709cff0142c9
Reviewed-on: https://chromium-review.googlesource.com/830174
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524428}
[modify] https://crrev.com/ffe75f56318e0e3c2f29ee0a1156c85f83dfad2e/base/message_loop/message_pump_win.cc

Cc: bokan@chromium.org dtapu...@chromium.org
I check spyxx with my CL, the mouse button down/up are route to correct window.

Comment 6 by dchau...@etouch.net, Dec 18 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3298.0
Update:-
 Tested this issue on Windows (7,8,10) machines using latest Chrome canary build# 65.0.3298.0 and fix is working as expected i.e. Copies count decreases/increases properly according to the click. Hence adding TE Verified labels. 

Please find the attached screen-cast for reference.

Thanks..!
LatestCanary Behavior.mp4
1.1 MB View Download
Labels: -Pri-1 Pri-3
Status: Fixed (was: Assigned)
The new approach of 713907, 596190 does not effect print page. Close this issue.

Sign in to add a comment