New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795221 link

Starred by 1 user
Status: Fixed
Owner:
█ kochi@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
Cc:
rakina@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocked on:
issue 805383
issue 806216
Blocking:
issue 624724



Sign in to add a comment

Clean up dead code for multiple shadow roots

Project Member Reported by kochi@chromium.org, Dec 15 2017 
After multiple shadow roots support was removed ( issue 489947 )
we can do code cleanup for dead code that still lives in the codebase.

Comment 1 by kochi@chromium.org, Dec 15 2017

Blocking: 624724

Comment 2 by kochi@chromium.org, Jan 11 2018

Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b7c29b02de585610b2287a8054781a5e8e9d019

commit 9b7c29b02de585610b2287a8054781a5e8e9d019
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 05:27:16 2018

Remove dead code after multiple shadow removal [1/5]

Remove some unnecessary members of ShadowRootRareDataV0:
 - younger_shadow_root_
 - older_shadow_root_
 - shadow_insertion_point_of_younger_shadow_root_

and remove code that refers them.

Bug:  795221 
Change-Id: Ic59efd874e3ce68249ecdcd9e0ca02e6ad549e8a
Reviewed-on: https://chromium-review.googlesource.com/828003
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531443}
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ElementShadow.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ShadowRoot.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ShadowRootRareDataV0.h
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/V0InsertionPoint.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/V0InsertionPoint.h
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/events/EventPath.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/dom/ng/flat_tree_traversal_ng.cc
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/html/HTMLShadowElement.h
[modify] https://crrev.com/9b7c29b02de585610b2287a8054781a5e8e9d019/third_party/WebKit/Source/core/page/FocusController.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896

commit 9784fa2f0eb5d8ec5055c8f79c76f30547b8b896
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 06:01:44 2018

Remove dead code after multiple shadow removal [2/5]

Remove
 - ElementShadow::YoungestShadowRoot()
 - ElementShadow::OldestShadowRoot()

TBR=mlamouri@chromium.org for media_controls

Bug:  795221 
Change-Id: I391b737acf04b45978ab1474725314442c979a06
Reviewed-on: https://chromium-review.googlesource.com/828344
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531452}
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.h
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ElementShadow.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ElementShadowV0.h
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/dom/ng/flat_tree_traversal_ng.cc
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/frame/MHTMLTest.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/9784fa2f0eb5d8ec5055c8f79c76f30547b8b896/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0087a4206b3f1de41972b541c701aee61d4cb79

commit f0087a4206b3f1de41972b541c701aee61d4cb79
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 07:35:24 2018

Remove dead code after multiple shadow removal [3/5]

Remove {Node,Element}::YoungestShadowRoot()

Bug:  795221 
Change-Id: I446674a06e5057a9aebbff3c96f7272aeede22e9
Reviewed-on: https://chromium-review.googlesource.com/831788
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531474}
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/editing/testing/SelectionSampleTest.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp
[modify] https://crrev.com/f0087a4206b3f1de41972b541c701aee61d4cb79/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElementTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/391d909bf8ff508c895164adae6aa5ab7cf4c454

commit 391d909bf8ff508c895164adae6aa5ab7cf4c454
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 08:20:04 2018

Remove dead code after multiple shadow removal [4/5]

Remove ShadowRoot::{Younger,Older}ShadowRoot

Bug:  795221 
Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997
Reviewed-on: https://chromium-review.googlesource.com/831810
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531478}
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/dom/TreeScope.h
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/dom/events/EventPath.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/html/HTMLShadowElement.h
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/391d909bf8ff508c895164adae6aa5ab7cf4c454/third_party/WebKit/Source/core/testing/Internals.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b95262849c3c386d4216f5fc08816970911c256

commit 0b95262849c3c386d4216f5fc08816970911c256
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 10:03:12 2018

Remove dead code after multiple shadow removal [5/5]

Remove window.internals.{youngest/oldest/younger}ShadowRoot
Adjust layout tests.

Bug:  795221 
Change-Id: I75024668007771c87ddd9598fbd1728859d7f9e9
Reviewed-on: https://chromium-review.googlesource.com/831815
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531490}
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/editing/selection/stay-in-textarea.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-user-agent-shadow.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-should-not-change-datetimelocal-time.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-clearbutton-preventdefault-mousecapture-status.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/resources/common-clearbutton-change-and-input-events.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-click-in-iframe.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/resources/common.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/shadow-dom/resources/focus-utils.js
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/0b95262849c3c386d4216f5fc08816970911c256/third_party/WebKit/Source/core/testing/Internals.idl
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ff48169805c9e44bd64868baf78934418e6bae

commit 05ff48169805c9e44bd64868baf78934418e6bae
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 15:33:23 2018

Revert "Remove dead code after multiple shadow removal [5/5]"

This reverts commit 0b95262849c3c386d4216f5fc08816970911c256.

Reason for revert:  crbug.com/805383 
This and some prior changes may have made Mac bots' layout tests
flaky.

Original change's description:
> Remove dead code after multiple shadow removal [5/5]
> 
> Remove window.internals.{youngest/oldest/younger}ShadowRoot
> Adjust layout tests.
> 
> Bug:  795221 
> Change-Id: I75024668007771c87ddd9598fbd1728859d7f9e9
> Reviewed-on: https://chromium-review.googlesource.com/831815
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531490}

TBR=kochi@chromium.org,hayato@chromium.org,futhark@chromium.org

Change-Id: I02653b0f2f0874465c6078aa46c6ebc9365148a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  795221 
Reviewed-on: https://chromium-review.googlesource.com/883921
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531534}
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/editing/selection/stay-in-textarea.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-user-agent-shadow.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-should-not-change-datetimelocal-time.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-clearbutton-preventdefault-mousecapture-status.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/resources/common-clearbutton-change-and-input-events.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-click-in-iframe.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/resources/common.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/shadow-dom/resources/focus-utils.js
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/05ff48169805c9e44bd64868baf78934418e6bae/third_party/WebKit/Source/core/testing/Internals.idl
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b575d46364b9beba14a00a6b9fadca799dda41b

commit 1b575d46364b9beba14a00a6b9fadca799dda41b
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 15:35:00 2018

Revert "Remove dead code after multiple shadow removal [4/5]"

This reverts commit 391d909bf8ff508c895164adae6aa5ab7cf4c454.

Reason for revert:  crbug.com/805383 
This and some prior changes may have made Mac bots' layout tests
flaky.

Original change's description:
> Remove dead code after multiple shadow removal [4/5]
> 
> Remove ShadowRoot::{Younger,Older}ShadowRoot
> 
> Bug:  795221 
> Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997
> Reviewed-on: https://chromium-review.googlesource.com/831810
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531478}

TBR=kochi@chromium.org,hayato@chromium.org,futhark@chromium.org

Change-Id: I6fd245114974dee2ed342d5b38e8cc3541b78794
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  795221 
Reviewed-on: https://chromium-review.googlesource.com/883822
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531536}
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/dom/TreeScope.h
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/dom/events/EventPath.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/html/HTMLShadowElement.h
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/1b575d46364b9beba14a00a6b9fadca799dda41b/third_party/WebKit/Source/core/testing/Internals.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5646f547e03f79baf219ab6465ceb9cc0740b36c

commit 5646f547e03f79baf219ab6465ceb9cc0740b36c
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jan 24 15:37:59 2018

Revert "Remove dead code after multiple shadow removal [3/5]"

This reverts commit f0087a4206b3f1de41972b541c701aee61d4cb79.

Reason for revert:  crbug.com/805383 
This and some following changes may have made Mac bots' layout tests
flaky.

Original change's description:
> Remove dead code after multiple shadow removal [3/5]
> 
> Remove {Node,Element}::YoungestShadowRoot()
> 
> Bug:  795221 
> Change-Id: I446674a06e5057a9aebbff3c96f7272aeede22e9
> Reviewed-on: https://chromium-review.googlesource.com/831788
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531474}

TBR=kochi@chromium.org,hayato@chromium.org,mlamouri@chromium.org,futhark@chromium.org

Change-Id: I3510152c4e9e4126151b957d0de478e80a47a470
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  795221 
Reviewed-on: https://chromium-review.googlesource.com/883823
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531539}
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/editing/testing/SelectionSampleTest.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp
[modify] https://crrev.com/5646f547e03f79baf219ab6465ceb9cc0740b36c/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElementTest.cpp

Comment 11 by kochi@chromium.org, Jan 29 2018

Blockedon: 805383

Comment 12 by kochi@chromium.org, Jan 29 2018

Blockedon: 806216
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88e32ff524468c37012659dc81a020575c0b5db

commit f88e32ff524468c37012659dc81a020575c0b5db
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Mon Jan 29 08:02:14 2018

Revert "Remove dead code after multiple shadow removal [2/5]"

This reverts commit 9784fa2f0eb5d8ec5055c8f79c76f30547b8b896.

Reason for revert:  crbug.com/806216 , potential cause for CSS perf
regression (and 3/5-5/5 were already reverted due to  crbug.com/805383 
and have not relanded).

Original change's description:
> Remove dead code after multiple shadow removal [2/5]
>
> Remove
>  - ElementShadow::YoungestShadowRoot()
>  - ElementShadow::OldestShadowRoot()
>
> TBR=mlamouri@chromium.org for media_controls
>
> Bug:  795221 
> Change-Id: I391b737acf04b45978ab1474725314442c979a06
> Reviewed-on: https://chromium-review.googlesource.com/828344
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531452}

TBR=kochi@chromium.org,hayato@chromium.org,futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  795221 ,  806216 
Change-Id: I123f9da565b8b43cbb808d613c35171321b76c49
Reviewed-on: https://chromium-review.googlesource.com/890842
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532347}
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.h
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ElementShadow.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ElementShadowV0.h
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/dom/ng/flat_tree_traversal_ng.cc
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/frame/MHTMLTest.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/f88e32ff524468c37012659dc81a020575c0b5db/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea4f39103719b2eb48e1efbd2a0af86255f2713

commit 9ea4f39103719b2eb48e1efbd2a0af86255f2713
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Tue Feb 06 09:30:32 2018

Reland "Remove dead code after multiple shadow removal [2/5]"

This is a reland of 9784fa2f0eb5d8ec5055c8f79c76f30547b8b896.
(was: reverted due to potential perf regresssion  crbug.com/806216 )

Original change's description:
> Remove dead code after multiple shadow removal [2/5]
>
> Remove
>  - ElementShadow::YoungestShadowRoot()
>  - ElementShadow::OldestShadowRoot()
>
> TBR=mlamouri@chromium.org for media_controls
>
> Bug:  795221 
> Change-Id: I391b737acf04b45978ab1474725314442c979a06
> Reviewed-on: https://chromium-review.googlesource.com/828344
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531452}

TBR=mlamouri@chromium.org for media_controls

Bug:  795221 
Change-Id: I01c0bc0565c525346c4de2e0f51a2b81c945accf
Reviewed-on: https://chromium-review.googlesource.com/903643
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534668}
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.h
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ElementShadow.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ElementShadowV0.h
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/dom/ng/flat_tree_traversal_ng.cc
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/frame/MHTMLTest.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/9ea4f39103719b2eb48e1efbd2a0af86255f2713/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp

Comment 15 by kochi@chromium.org, Feb 7 2018 

After relanding [2/5], I don't see the regression on linux blink perf bot
on blink_perf.css/ClassInvalidation.

https://chromeperf.appspot.com/report?sid=8327515919c408e4e71adb92dc5d06d5adfe3a58143751188bce13c06d98a50d
Test: ChromiumPerf/linux-release/blink_perf.css/ClassInvalidation
Value: 8,364.7 (± 2.61021)
Point ID: 534669
Time added: 2018-02-06T11:06:47.000Z
Chromium Commit Position range: 534629 - 534669 
Chromium Git Hash range: 2f44373 - 6e6a9ab 
V8 Commit Position range: 03c145d - ebe77c4
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd73d436e60d027527393cb5235e7e8b181f1ea

commit 6bd73d436e60d027527393cb5235e7e8b181f1ea
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Feb 07 06:45:58 2018

Reland "Remove dead code after multiple shadow removal [3/5]"

This is a reland of f0087a4206b3f1de41972b541c701aee61d4cb79.

This was reverted due to  crbug.com/805383 , which claims that
Mac bots' layout tests became flaky.

Not sure it was due to this change, relanding as is.

Original change's description:
> Remove dead code after multiple shadow removal [3/5]
>
> Remove {Node,Element}::YoungestShadowRoot()
>
> Bug:  795221 
> Change-Id: I446674a06e5057a9aebbff3c96f7272aeede22e9
> Reviewed-on: https://chromium-review.googlesource.com/831788
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531474}

TBR=hayato@chromium.org, futhark@chromium.org, mlamouri@chromium.org

Bug:  795221 
Change-Id: I25bad00cd67c418f8bfd0d42acea88bcc8ad1fb8
Reviewed-on: https://chromium-review.googlesource.com/906082
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534937}
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/ElementShadow.h
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/editing/testing/SelectionSampleTest.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp
[modify] https://crrev.com/6bd73d436e60d027527393cb5235e7e8b181f1ea/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElementTest.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67f7bc4dbf87ba2270c98516871a25fcc303558

commit a67f7bc4dbf87ba2270c98516871a25fcc303558
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Thu Feb 15 05:59:03 2018

Reland "Remove dead code after multiple shadow removal [4/5]"

This is a reland of 391d909bf8ff508c895164adae6aa5ab7cf4c454.

This was once reverted due to potential cause for Mac bot's
flakiness:  crbug.com/805383 

Original change's description:
> Remove dead code after multiple shadow removal [4/5]
>
> Remove ShadowRoot::{Younger,Older}ShadowRoot
>
> Bug:  795221 
> Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997
> Reviewed-on: https://chromium-review.googlesource.com/831810
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531478}

TBR=hayato@chromium.org, futhark@chromium.org

Bug:  795221 
Change-Id: I61a8c2d7b39398fc676515f67a7c0d0a9536da22
Reviewed-on: https://chromium-review.googlesource.com/920941
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536951}
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/dom/TreeScope.h
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/dom/events/EventPath.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/html/HTMLShadowElement.h
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/a67f7bc4dbf87ba2270c98516871a25fcc303558/third_party/WebKit/Source/core/testing/Internals.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1

commit c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Thu Feb 15 10:45:59 2018

Reland "Remove dead code after multiple shadow removal [5/5]"

This is a reland of 0b95262849c3c386d4216f5fc08816970911c256.

The original CL was once reverted due to potential cause for
Mac bot's flakiness:  crbug.com/805383 

Original change's description:
> Remove dead code after multiple shadow removal [5/5]
>
> Remove window.internals.{youngest/oldest/younger}ShadowRoot
> Adjust layout tests.
>
> Bug:  795221 
> Change-Id: I75024668007771c87ddd9598fbd1728859d7f9e9
> Reviewed-on: https://chromium-review.googlesource.com/831815
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531490}

Bug:  795221 
Change-Id: I854ed889f811f3768ac95653b74ddd3f30ce6b5a
Reviewed-on: https://chromium-review.googlesource.com/919923
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536984}
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/editing/selection/stay-in-textarea.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-user-agent-shadow.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-should-not-change-datetimelocal-time.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-clearbutton-preventdefault-mousecapture-status.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/resources/common-clearbutton-change-and-input-events.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-click-in-iframe.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/resources/common.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-focus.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/shadow-dom/resources/focus-utils.js
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/c78013e0e5f3c501f016cd0ca3a9b9d257b1faf1/third_party/WebKit/Source/core/testing/Internals.idl
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad2a78a9079604fe44c69476cde0f60c7ce1778

commit dad2a78a9079604fe44c69476cde0f60c7ce1778
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Thu Feb 15 16:30:56 2018

Remove redundant IsShadowHost()

As multiple shadow roots are gone, checking the value from
GetShadowRoot() is enough for checking the shadow root's
existence.

This is a minor cleanup and should not change any behavior.

Bug:  795221 
Change-Id: I16c2e1b22e447cc721bfa73876b4e84fdf352b67
Reviewed-on: https://chromium-review.googlesource.com/920574
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537041}
[modify] https://crrev.com/dad2a78a9079604fe44c69476cde0f60c7ce1778/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp

Comment 20 by kochi@chromium.org, Feb 16 2018

Status: Fixed (was: Started)
►

Sign in to add a comment