New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 774345



Sign in to add a comment

milo build page: displays swarming task id instead of build number or id

Project Member Reported by no...@chromium.org, Dec 15 2017

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/23510
title says "Builder linux_chromium_rel_ng Build 3a7171e42552b610" instead of "Builder linux_chromium_rel_ng Build 23510".

the reason is bug 774345
 

Comment 1 by efoo@chromium.org, Dec 22 2017

Labels: LUCI-KnownIssues-UI
Status: Available (was: Untriaged)

Comment 3 by efoo@chromium.org, Jan 25 2018

Labels: luci-blocker-migration

Comment 4 by efoo@chromium.org, Jan 25 2018

Labels: -LUCI-Blocker-M4
Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Nodir mentioned this should be easy to fix. Ryan, can you take a look at this?

Comment 5 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/54a4a42d5cca148b7e0ec8020b4ca907a555f354

commit 54a4a42d5cca148b7e0ec8020b4ca907a555f354
Author: Ryan Tseng <hinoka@google.com>
Date: Tue Feb 13 20:16:40 2018

[milo] Display buildnumber for buildbucket builds if available

By parsing it out of the buildsummary's BuildID.

The effect is that instead of displaying SwarmingID, all
builds will prefer to display a buildbucket build number, or
buildbucket build ID if available.

Bug:  795187 
Change-Id: I642a53aac0421e41a7449b2f54ab3e5a05d34f18
Reviewed-on: https://chromium-review.googlesource.com/914935
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/54a4a42d5cca148b7e0ec8020b4ca907a555f354/milo/buildsource/buildbucket/build.go
[modify] https://crrev.com/54a4a42d5cca148b7e0ec8020b4ca907a555f354/milo/common/model/build_summary.go

Status: Fixed (was: Assigned)

Sign in to add a comment