New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795182 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus lost is seen on save password bubble after pressing Tab key.

Reported by pranjali...@etouch.net, Dec 15 2017

Issue description

Chrome Version:65.0.3294.3 (Official Build) b87c6558819ba776f737b5662fbe3eff149af66a-refs/branch-heads/3294@{#4} 

OS:Mac(10.12.6,10.13.2)

Precondition:Sign in to gmail account with valid credentials.

Steps to reproduce:
1.Launch Chrome and go to https://mail.google.com/mail/u/0/#inbox URL.
2.Click on Key icon on omnibox and click on save button on save password bubble.
3.Now press Tab key 3-4 times and observe.

Actual Result:Focus lost is seen on save password bubble after pressing Tab key.
Expected Result:Focus lost should not be seen on save password bubble after pressing Tab key.

This is a regression issue, broken in M-65 series, Using the per-revision bisect providing the bisect results,

Good Build:65.0.3292.0
Bad Build:65.0.3293.0

You are probably looking for a change made after 523625 (known good), but no later than 523626 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/a7f4ab11cf9b65467aab860edc38e613d604b37d..ebe803acafc7cc3bd273c529edbba8f45b37b445

Suspect:https://chromium.googlesource.com/chromium/src/+/ebe803acafc7cc3bd273c529edbba8f45b37b445

pbos@:Kindly help to reassign, if your changes are not related to this issue.


 
Actual_result.mov
3.9 MB Download
Expected_result.mov
3.4 MB Download
Note:
above issue is also reproducible on chrome canary 65.0.3295.0 build. 
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by battre@chromium.org, Dec 18 2017

Cc: vasi...@chromium.org

Comment 4 by pbos@chromium.org, Dec 18 2017

Cc: pbos@chromium.org
 Issue 795186  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102f21a075a23845645b0a0f0e8c0b29aa579327

commit 102f21a075a23845645b0a0f0e8c0b29aa579327
Author: Peter Boström <pbos@chromium.org>
Date: Mon Dec 18 22:56:38 2017

Remove FocusBehavior from password labels.

Removes ACCESSIBLE_ONLY focus behavior which makes this label iterable
on Mac and causes lost focus behavior.

Bug:  chromium:795182 ,  chromium:795186 
Change-Id: I6e87919a236f6ccac9aae74166e99659bb1ca16e
Reviewed-on: https://chromium-review.googlesource.com/832809
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524842}
[modify] https://crrev.com/102f21a075a23845645b0a0f0e8c0b29aa579327/chrome/browser/ui/views/passwords/manage_password_items_view.cc

Comment 6 by pbos@chromium.org, Dec 18 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M65 TE-Verified-65.0.3299.0
Rechecked the above issue on Mac(10.12.6,10,13.2) OS with latest canary chrome version :65.0.3299.0 and fix is working as intended.
Kindly refer the attached screen cast for reference.
Result.mov
2.8 MB Download

Sign in to add a comment