New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Android PNG image decode perf regression 524076 - 524196

Project Member Reported by noel@chromium.org, Dec 15 2017

Issue description

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 15 2017

Cc: dalecur...@chromium.org
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author dalecurtis@chromium.org ===

Hi dalecurtis@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Dale Curtis
  Commit : 74612b7459881f9194f4d404e4f6688efe0bd8f5
  Date   : Thu Dec 14 20:56:19 2017
  Subject: Plumb UKM PlayerID for WatchTime and VideoDecodeStats recording.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : blink_perf.image_decoder
  Metric       : ImageFrameGenerator::decode/decode-png.html
  Change       : 0.93% | 144.717396429 -> 143.250064286

Revision             Result                  N
chromium@524108      144.717 +- 2.91934      14      good
chromium@524141      144.058 +- 3.21398      21      good
chromium@524158      144.029 +- 2.5971       14      good
chromium@524166      143.895 +- 2.28642      21      good
chromium@524167      138.607 +- 1.30364      6       bad       <--
chromium@524168      138.883 +- 1.28537      6       bad
chromium@524170      138.811 +- 1.25848      6       bad
chromium@524174      143.25 +- 2.45236       14      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=decode.png.html blink_perf.image_decoder

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8960170161463110608


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Dec 15 2017

Cc: ajwong@chromium.org
Owner: ajwong@chromium.org

=== Auto-CCing suspected CL author ajwong@chromium.org ===

Hi ajwong@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Albert J. Wong
  Commit : 8c29b757124e1ceb921ad61d023b6b741eda92d4
  Date   : Thu Dec 14 18:48:00 2017
  Subject: Enable frame pointers on arm32.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : blink_perf.image_decoder
  Metric       : ImageFrameGenerator::decode/decode-png.html
  Change       : 2.49% | 300.001366667 -> 307.465575

Revision             Result                   N
chromium@524075      300.001 +- 0.660499      6      good
chromium@524106      300.226 +- 0.514386      6      good
chromium@524121      300.251 +- 1.31323       6      good
chromium@524125      299.933 +- 0.837817      6      good
chromium@524126      299.95 +- 0.894075       6      good
chromium@524127      307.506 +- 1.56375       6      bad       <--
chromium@524129      307.522 +- 1.9798        6      bad
chromium@524136      307.398 +- 1.0658        6      bad
chromium@524196      307.466 +- 1.76839       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=decode.png.html blink_perf.image_decoder

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8960170186960666256


For feedback, file a bug with component Speed>Bisection

Comment 5 by noel@chromium.org, Dec 15 2017

Cc: scroggo@chromium.org cblume@chromium.org

Comment 6 by noel@chromium.org, Dec 15 2017

Summary: Android PNG image decode perf regression 524076 - 524196 (was: Android PNG image per regression 524076 - 524196 )

Sign in to add a comment