Flash while dismissing toast notifications |
|||
Issue descriptionChrome version: 65.0.3287.0, ChromeOS version: 10210.0.0 Repro steps: 1. Get a toast notification somehow 2. Go to swipe to dismiss with your finger (flinging motion) Expected behaviour: Becomes slowly transparent and disappears Actual behaviour: Becomes slowly transparent, but briefly flashes to what appears to be 100% opacity as soon as your finger is lifted. I think this is a fairly old bug - I think recall seeing it on M62.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9ca777a91443bf488e05c8b3bb05618abcef11e commit c9ca777a91443bf488e05c8b3bb05618abcef11e Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Dec 19 09:02:21 2017 Do not fade out if notification is already transparent. If a notification was removed, ToastContentsView was always starting fade out animation with its opacity 1.0 in StartFadeOut. Usually it works fine, but on touch devices, the notification's opacity is already set to 0.0 by SlideOutController, thus resulted in flashing artifact. TEST=manual, message_center_unittests BUG= 795171 Change-Id: Ide812e898a33e01b5750bad134b4d5e2e9c839a3 Reviewed-on: https://chromium-review.googlesource.com/831385 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524974} [modify] https://crrev.com/c9ca777a91443bf488e05c8b3bb05618abcef11e/ui/message_center/views/toast_contents_view.cc
,
Dec 19 2017
,
Jul 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tetsui@chromium.org
, Dec 18 2017