New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Message for volume unmount failure due to operation ongoing etc.

Project Member Reported by yamaguchi@chromium.org, Dec 15 2017

Issue description

We have added a message for failing to unmount a provided volume (e.g. ZIP file) to make it distinguished from a physical USB drive. The text resource was still tentative.
https://chromium-review.googlesource.com/c/chromium/src/+/789170/6/chrome/app/chromeos_strings.grdp#310

It has been pointed out that "volume" and "unmount" is not friendly for users and our translators.
I think there are 2 underlying issues around it.

- The terms "volume unmount" should be replaced with other term(s), like "disconnect", "safely close the archive", "stop" or so.
- The concept of mounting and unmounting of provided volumes, especially an archive, might not be the best UX. By this reason there may not be a good way to describe this in a natural language.

But for now, we need to revise the messages for "unmount failure due to ongoing operations" to a better ones.
 

Comment 1 Deleted

I've made a draft proposal. Feel free to add comments inline.
https://chromium-review.googlesource.com/c/chromium/src/+/828184

Comment 3 by srahim@chromium.org, Dec 18 2017

I left comments in the code review. LMK if we need to iterate further.
Cc: weifangsun@chromium.org
Owner: yamaguchi@chromium.org
Status: Assigned (was: Unconfirmed)
yamaguchi@ - It looks like this update was included in M65?
Labels: -M-65 M-66
No, it is not. The change has been pending due to other priorities. The update can be included in M66.

We'd like to have a final confirmation by srahim@.
https://chromium-review.googlesource.com/c/chromium/src/+/828184#message-a40cac8b47bfb57c2c52e04aecb769ce7ebae513
Also attached the screenshot.
cant_disconnect_from_an_archive_or_virtual_disk.png
12.5 KB View Download

Comment 6 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-Zip
<files-triage>

Comment 7 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/894211b483c2db4525bbb8a292dc24d35d3ac391

commit 894211b483c2db4525bbb8a292dc24d35d3ac391
Author: Tatsuhisa Yamaguchi <yamaguchi@google.com>
Date: Fri Mar 09 07:43:02 2018

Improve messaging for provided volume unmount failures.

Bug:  795167 
Change-Id: I4223e26d23885c350337aefb8abd991427435a05
Reviewed-on: https://chromium-review.googlesource.com/828184
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542058}
[modify] https://crrev.com/894211b483c2db4525bbb8a292dc24d35d3ac391/chrome/app/chromeos_strings.grdp

Labels: -M-66 M-67
Status: Fixed (was: Assigned)
Change submitted. Punting to M-67 for waiting regular resource translation cycle.

Sign in to add a comment