New issue
Advanced search Search tips

Issue 795160 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Puppet pre-submit tests broken for some files

Reported by jrbarnette@chromium.org, Dec 15 2017

Issue description

Trivial changes to some puppet files cause the pre-submit
checks to fail when uploading.

To reproduce:
  * Get an up-to-date repo with chromeos-admin.
  * Make the follow change:
        echo >>puppet/modules/lab/manifests/push_master.pp
  * Create a branch with the change, and try `repo upload .`

The upload will fail with the error seen in the attached file.
 
upload.txt
16.4 KB View Download
After some exploration, I've learned that setting LANG=C.UTF-8
or LANG=en_US.UTF-8 is sufficient to make the problem go away.

Labels: -Pri-2 Pri-3
Status: Started (was: Assigned)
https://chrome-internal-review.googlesource.com/c/chromeos/chromeos-admin/+/530778

Add a check for this
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/fb6b895f5a57ab1077eb627050b49b41c8533c06

commit fb6b895f5a57ab1077eb627050b49b41c8533c06
Author: Allen Li <ayatane@chromium.org>
Date: Tue Dec 19 19:29:11 2017

Status: Fixed (was: Started)

Sign in to add a comment