New issue
Advanced search Search tips

Issue 795151 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-typed-om] CSSMatrixComponentOptions's is2D should be not have default value.

Project Member Reported by hs1217....@samsung.com, Dec 15 2017

Issue description

CSSMatrixComponentOptions's is2D should be not have default value

https://drafts.css-houdini.org/css-typed-om-1/#dictdef-cssmatrixcomponentoptions
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9eef8a4e0d7c37a65c0e840fd1b0ec2026538a

commit be9eef8a4e0d7c37a65c0e840fd1b0ec2026538a
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Dec 15 05:59:49 2017

[css-typed-om] is2D attribute should be not have default value

CSSMatrixComponentOptions's is2D should be not have default value
present, it has default value as false.
when second paramter is not CSSMatrixComponentOptions
in CSSMatrixComponent's constructor, is2D will be false.
it seems work well like spec but it was not match spec.
so sync up with spec.

https://drafts.css-houdini.org/css-typed-om-1/#dictdef-cssmatrixcomponentoptions

Bug:  795151 
Change-Id: Ib6ac6ad3793b029d079f50d787994b4bf058b7fe
Reviewed-on: https://chromium-review.googlesource.com/824282
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524341}
[modify] https://crrev.com/be9eef8a4e0d7c37a65c0e840fd1b0ec2026538a/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html
[modify] https://crrev.com/be9eef8a4e0d7c37a65c0e840fd1b0ec2026538a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.cpp
[modify] https://crrev.com/be9eef8a4e0d7c37a65c0e840fd1b0ec2026538a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponentOptions.idl

Status: Fixed (was: Started)

Sign in to add a comment