LSAN detects leaks for an in-tree fontconfig build |
|||||||||
Issue descriptionPlease see this build: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/511822 There are many new failures caused by instrumenting fontconfig with LSAN. These failures were not seen before because we used to use the (uninstrumented) system library. For now, the failures will be suppressed.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c commit 5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Dec 19 23:05:34 2017 Revert "Statically link fontconfig on Linux" This reverts commit 4f1a60552748d150783655ee6f7b6f7084e3af95. Reason for revert: This CL caused time outs in browser tests - see https://crbug.com/796292 Original change's description: > Statically link fontconfig on Linux > > This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks > and races detected by LSAN and TSAN. For now, these will be suppressed since > these issues were preexisting, but instrumenting fontconfig exposed the issues. > > R=dnicoara@chromium.org,dpranke@chromium.org > BUG=795110, 795148 > > Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7 > Reviewed-on: https://chromium-review.googlesource.com/826403 > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524389} TBR=dpranke@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 795110, 795148 Change-Id: Id224fdcbfb0ca3373f6219b66252a8970072675b Reviewed-on: https://chromium-review.googlesource.com/834869 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#525173} [delete] https://crrev.com/7f446eb0ecff4014853501cd6d50fcf8ff6fa98b/build/linux/unbundle/fontconfig.gn [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/build/linux/unbundle/replace_gn_files.py [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/build/sanitizers/lsan_suppressions.cc [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/build/sanitizers/tsan_suppressions.cc [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c/third_party/fontconfig/fontconfig.gni
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f919d2d86e54c851b0327740a330d152b07ed5 commit 65f919d2d86e54c851b0327740a330d152b07ed5 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Dec 22 06:20:09 2017 Reland "Statically link fontconfig on Linux" This reverts commit 5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c Reason for revert: See comment https://bugs.chromium.org/p/chromium/issues/detail?id=796292#c28 > This reverts commit 4f1a60552748d150783655ee6f7b6f7084e3af95. > > Reason for revert: This CL caused time outs in browser tests - see https://crbug.com/796292 > > Original change's description: > > Statically link fontconfig on Linux > > > > This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks > > and races detected by LSAN and TSAN. For now, these will be suppressed since > > these issues were preexisting, but instrumenting fontconfig exposed the issues. > > > > R=dnicoara@chromium.org,dpranke@chromium.org > > BUG=795110, 795148 > > > > Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7 > > Reviewed-on: https://chromium-review.googlesource.com/826403 > > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#524389} > > TBR=dpranke@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 795110, 795148 > Change-Id: Id224fdcbfb0ca3373f6219b66252a8970072675b > Reviewed-on: https://chromium-review.googlesource.com/834869 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525173} R=dpranke@chromium.org TBR=dnicoara@chromium.org BUG=795110, 795148 , 796292 Change-Id: I47a2225cb9cc255721b521cbb790d9eb70e0b3b9 Reviewed-on: https://chromium-review.googlesource.com/841627 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#525945} [add] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/build/linux/unbundle/fontconfig.gn [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/build/linux/unbundle/replace_gn_files.py [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/build/sanitizers/lsan_suppressions.cc [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/build/sanitizers/tsan_suppressions.cc [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/65f919d2d86e54c851b0327740a330d152b07ed5/third_party/fontconfig/fontconfig.gni
,
Jan 8 2018
,
May 22 2018
Issue 824597 has been merged into this issue.
,
May 22 2018
This crash occurs very frequently on linux platform and is likely preventing the fuzzer inferno_twister from making much progress. Fixing this will allow more bugs to be found. Marking this bug as a blocker for next Beta release. If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
,
May 22 2018
This crash occurs very frequently on linux platform and is likely preventing the fuzzer inferno_twister from making much progress. Fixing this will allow more bugs to be found. Marking this bug as a blocker for next Beta release. If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
,
May 22 2018
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
,
May 22 2018
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
,
May 22 2018
,
May 24 2018
thomasanderson@/sunnyps@/ some one from internals>core team , please take a look into this issue as it is marked as RBB for M68. Thanks in advance..!
,
May 24 2018
This should not be a blocker.
,
Aug 23
,
Sep 4
ClusterFuzz testcase 6215641246466048 is flaky and no longer crashes, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 15 2017