New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795123 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Select a better fallback display mode when the preferred mode is not supported

Project Member Reported by afakhry@chromium.org, Dec 14 2017

Issue description

If the display preferred mode is not supported, it will be filtered out, and then Chrome will pick up the first mode in the list which is likely to be the highest resolution mode.

What we should do is to look for a mode with the same size as the preferred mode and favor that first before defaulting to the highest resolution.
 

Comment 1 by igo@chromium.org, Dec 14 2017

Cc: chromeos-fizz@google.com igo@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce89151156cb2a69f2f0ea332742768c824f02e

commit 1ce89151156cb2a69f2f0ea332742768c824f02e
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Wed Dec 20 18:13:34 2017

Select a better fallback native display mode if no preferred mode is available

If the display preferred mode is not supported, it will be filtered out, and
then Chrome will pick up the first mode in the list which is likely to be
the highest resolution mode.

We should first try to find a mode with an equal size to the active pixels
size in the first detailed timing descriptor. If that fails too, then we can
default to the first highest resolution.

BUG= 795123 

Change-Id: Ibd81fdd4c86234a5d5bf6e78e55645c3419626d6
Reviewed-on: https://chromium-review.googlesource.com/828467
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525374}
[modify] https://crrev.com/1ce89151156cb2a69f2f0ea332742768c824f02e/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/1ce89151156cb2a69f2f0ea332742768c824f02e/ui/ozone/platform/drm/common/drm_util.h
[modify] https://crrev.com/1ce89151156cb2a69f2f0ea332742768c824f02e/ui/ozone/platform/drm/common/drm_util_unittest.cc

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment