KitchenSync Waterfall is broken due to failing sync_integration_tests (missing element) |
|||||||||
Issue description
These tests are consistently failing with the same message:
../../chrome/browser/ui/webui/signin/login_ui_test_utils.cc:185: Failure
Expected: "found"
To be equal to: message
Which is: "failed"
Failed to find element with id Email
After investigating I think the solution is fairly straightforward, so this could be a starter bug for Munich folks.
,
Dec 18 2017
vitaliii@ volunteered, thanks.
,
Dec 18 2017
,
Dec 21 2017
The CL is https://chromium-review.googlesource.com/c/chromium/src/+/840000. It looks like I figured it out :) but I am OOO until 2nd of January, if there is any urgency, please feel free to overtake. Otherwise, I will finish it when I am back.
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f0700e77d47b6f1f22f58408cd2529dd152367a commit 0f0700e77d47b6f1f22f58408cd2529dd152367a Author: vitaliii <vitaliii@chromium.org> Date: Tue Jan 02 11:02:43 2018 [Sync::IntegrationTests] Incorporate sign-in flow changes. Both old and new sign-in flows were changed, which broke sync integration tests. In this CL the sign-in code is updated for both flows: - for the old flow, only "Next" button id has been changed; - for the new flow: + new element ids; + different mechanism to wait for password field to appear. Previously this was achieved via javascript delay, however, the new flow has a redirect, which seems to reset injected javascript. The new approach is to inject new javascript for the check every second. Also the detection of the flow had to be changed, because now the flows do not share field ids anymore. Thus, the test just waits for either of the email fields to appear. Bug: 795071 Change-Id: I5bb940ab9e410837b0ce91c6bdcb38c91b95b29f Reviewed-on: https://chromium-review.googlesource.com/840000 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: Mihai Sardarescu (OOO until Jan 2nd) <msarda@chromium.org> Reviewed-by: Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#526457} [modify] https://crrev.com/0f0700e77d47b6f1f22f58408cd2529dd152367a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc [modify] https://crrev.com/0f0700e77d47b6f1f22f58408cd2529dd152367a/chrome/browser/ui/webui/signin/login_ui_test_utils.h
,
Jan 2 2018
,
Jan 8 2018
I could not verify the fix on the buildbots because they failed with an exception at an earlier step (issue 798358). That issue has been fixed, however, now the tests fail with a different error message (issue 799845) and it is not clear whether it happens after the code above.
,
Jan 12 2018
,
Jan 12 2018
,
Jan 17 2018
,
Jan 18 2018
We haven't observed this issue for a long time. Thus, I consider this fixed. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by zea@chromium.org
, Dec 14 2017Status: Assigned (was: Available)