New issue
Advanced search Search tips

Issue 795043 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Layout test rebaseline for legacy/NG name mismatch

Project Member Reported by xiaoche...@chromium.org, Dec 14 2017 
When running layout tests with LayoutNG enabled, we have some failures due to legacy/NG name mismatch. For example, we have "LayoutNGBlockFlow" in the layout tree dump, but the baseline expects "LayoutBlockFlow".

We already have code in test runner recognizing such failures. However, they are still treated as failures.

We need to:

1. Change layout test runner to return PASS for such mismatch

2. When LayoutNG goes to the "test" stage, rebaseline all such tests, and then clean up relevant code in test runner

Comment 1 by xiaoche...@chromium.org, Dec 14 2017

Owner: xiaoche...@chromium.org
Status: Assigned (was: Available)
I'll start with

1. Change layout test runner to return PASS for such mismatch
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dfa5b8499504e4b4062ac949116b820f4196829

commit 8dfa5b8499504e4b4062ac949116b820f4196829
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Dec 15 17:51:05 2017

[webkitpy] Treat LayoutNG name mismatch as PASS

This patch changes the layout test runner to treat LayoutNG name
mismatch (e.g., LayoutBlockFlow vs. LayoutNGBlockFlow) as PASS instead
of TEXT failure, to reduce noise in test result.

Bug:  795043 
Change-Id: Ia0a358f7ccf47cc809fff6b20eea1847d4754413
Reviewed-on: https://chromium-review.googlesource.com/828276
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524407}
[modify] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Comment 3 by xiaoche...@chromium.org, Dec 15 2017

Owner: ----
Status: Available (was: Assigned)

Comment 4 by e...@chromium.org, Oct 23

Status: Fixed (was: Available)
►

Sign in to add a comment