New issue
Advanced search Search tips

Issue 795027 link

Starred by 1 user
Status: Fixed
Owner:
kkhorimoto@chromium.org
Closed: Dec 2017
Cc:
marq@chromium.org
edchin@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ChromeCoordinators should have access to a ios::ChromeBrowserState.

Project Member Reported by kkhorimoto@chromium.org, Dec 14 2017 
This will be accessible via the Browser object after converting to BrowerCoordinator (Issue 793890), so it makes sense to include it in ChromeCoordinator in the interim so that new KeyedServices can be accessed by coordinators.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00474d2593912138355ea0e239872e1ee557463f

commit 00474d2593912138355ea0e239872e1ee557463f
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Dec 18 21:15:51 2017

[iOS] Allow ChromeCoordinators access to BrowerStates.

This brings ChromeCoordinator closer to BrowserCoordinator, its planned
replacement.

Bug:  795027 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idc34f7ba1c312ece2846a2c3a2ff289a02f92d38
Reviewed-on: https://chromium-review.googlesource.com/828076
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524799}
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/chrome_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/chrome_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/chrome_root_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/chrome_root_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/BUILD.gn
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/context_menu/context_menu_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h
[modify] https://crrev.com/00474d2593912138355ea0e239872e1ee557463f/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm

Comment 2 by kkhorimoto@chromium.org, Dec 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment