New issue
Advanced search Search tips

Issue 795024 link

Starred by 1 user
Status: Fixed
Owner:
robliao@chromium.org
Closed: Dec 2017
Cc:
robliao@chromium.org
gab@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

TaskSchedulerTaskTrackerTest.LoadWillPostBeforeShutdownAndRunDuringShutdown Flaky?

Project Member Reported by robliao@chromium.org, Dec 14 2017 
[ RUN      ] TaskSchedulerTaskTrackerTest.LoadWillPostBeforeShutdownAndRunDuringShutdown
[16880:16932:1214/101827.744:505703:FATAL:task_tracker.cc(602)] Check failed: new_num_incomplete_undelayed_tasks >= 0 (-1 vs. 0)
Backtrace:
        base::debug::StackTrace::StackTrace [0x100BE4C6+102] (E:\src\base\debug\stack_trace_win.cc:286)
        base::debug::StackTrace::StackTrace [0x100BD0B3+35] (E:\src\base\debug\stack_trace.cc:199)
        logging::LogMessage::~LogMessage [0x10132D65+149] (E:\src\base\logging.cc:581)
        base::internal::TaskTracker::DecrementNumIncompleteUndelayedTasks [0x10318069+249] (E:\src\base\task_scheduler\task_tracker.cc:603)
        base::internal::TaskTracker::RunNextTask [0x103176B6+726] (E:\src\base\task_scheduler\task_tracker.cc:319)
        base::internal::`anonymous namespace'::ThreadPostingAndRunningTask::Run [0x0140FF6F+1343] (E:\src\base\task_scheduler\task_tracker_unittest.cc:137)
        base::SimpleThread::ThreadMain [0x1035A509+169] (E:\src\base\threading\simple_thread.cc:68)
        base::`anonymous namespace'::ThreadFunc [0x1032E43D+317] (E:\src\base\threading\platform_thread_win.cc:91)
        BaseThreadInitThunk [0x76E362C4+36]
        RtlSubscribeWnfStateChangeNotification [0x77C70F79+1081]
        RtlSubscribeWnfStateChangeNotification [0x77C70F44+1028]

This test passed in the rerun
Retrying 3 tests (retry #1)
[2999/3001] TaskSchedulerTaskTrackerTest.LoadWillPostBeforeShutdownAndRunDuringShutdown (94 ms)

Comment 1 by robliao@chromium.org, Dec 15 2017

Owner: robliao@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d07daf95fd73f5fd92f22777e466ed9fa14e538d

commit d07daf95fd73f5fd92f22777e466ed9fa14e538d
Author: Robert Liao <robliao@chromium.org>
Date: Mon Dec 18 01:38:07 2017

Pass/store Task by value in TaskScheduler.

MessageLoop and the Blink scheduler pass/store tasks by value. This
avoids having a heap allocation for every task.

With this CL, TaskScheduler also passes/stores tasks by value. This
is a prerequisite to make the TaskScheduler and the Blink scheduler
work together.

ScopedTaskEnvironment refactor and previous review at https://chromium-review.googlesource.com/c/chromium/src/+/764531

Bug:  783309 ,  795024 
TBR: gab@chromium.org
Change-Id: I2ae01bed216f7d4e9c6a2615689df1817a2507d0
Reviewed-on: https://chromium-review.googlesource.com/826569
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524635}
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/priority_queue_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_pool.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_pool.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/test_utils.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/test_utils.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/test/scoped_task_environment.cc

Comment 3 by robliao@chromium.org, Dec 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment