New issue
Advanced search Search tips

Issue 795013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 760498



Sign in to add a comment

Capture more trace categories in startup benchmarks

Project Member Reported by dskiba@chromium.org, Dec 14 2017

Issue description

Currently start_with_url benchmarks capture only startup,blink.user_timing categories. 

This lefts out Java events, which are reported as EarlyJava, Java and toplevel categories.

And Java events are very important for understanding / evaluating startup performance.
 

Comment 1 by pasko@chromium.org, Dec 14 2017

yup, I tried to enable those and it failed subtly due to legacy reasons. The revamp of the benchmark is expected to handle it smoothly. The number there is not very trustworthy right now, and there is no earlyjava (yet), but there is "startup,toplevel".

See: https://codesearch.chromium.org/chromium/src/tools/perf/benchmarks/start_with_url.py?l=94

The benchmark name is 'experimental.startup.android.coldish', and we've got a few datapoints and traces recently: https://chromeperf.appspot.com/report?sid=9df0ec76b0fffc74931cc7bdcf44cd4d540f81bb34ccde3571c2211ec8360ee6

lemme try to add earlyjava to the new benchmark .. (tomorrow probably)

Comment 2 by pasko@chromium.org, Dec 27 2017

Blocking: 760498

Comment 3 by dskiba@chromium.org, Dec 27 2017

Owner: pasko@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by pasko@chromium.org, Dec 29 2017

Cc: -pasko@chromium.org dskiba@chromium.org
Labels: -Pri-3 Pri-2
Summary: Capture more trace categories in startup benchmarks (was: Capture more trace categories in start_with_url)
reformulating the title to remove the mention of the old benchmark, which we will hopefully stop using soon
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f04791010c6426468267548cdd48c14356bb1296

commit f04791010c6426468267548cdd48c14356bb1296
Author: Egor Pasko <pasko@chromium.org>
Date: Tue Jan 02 17:57:40 2018

Enable more categories for Android startup benchmark

Took me a while to realize that trace categories are case-sensitive..
otherwise all the pipeline to write the categories to the file and load
them in Chrome at startup seems to be working.

Bug:  795013 
Change-Id: I27691f0e8464e375130fe74640de36dbd71785ac
Reviewed-on: https://chromium-review.googlesource.com/846800
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526502}
[modify] https://crrev.com/f04791010c6426468267548cdd48c14356bb1296/tools/perf/benchmarks/start_with_url.py

Status: Fixed (was: Assigned)

Sign in to add a comment